You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/21 15:26:56 UTC

[GitHub] [kafka] joshuagrisham commented on pull request #9470: Add recursive support to Connect Cast and ReplaceField transforms, and support for casting complex types to either a native or JSON string.

joshuagrisham commented on pull request #9470:
URL: https://github.com/apache/kafka/pull/9470#issuecomment-713658739


   Hi @xvrl I pulled the latest trunk before I applied my changes (and should be included as part of the PR here) but I just wanted to mention, even after a fresh clone of trunk I saw some kind of issue in `ReplaceField` here https://github.com/apache/kafka/commit/eab61cad2c418786ab5e58aa1267f689d82a61d1#diff-00d03285691e372793d34d1f5090ddf4bdf27cadcd568de11e9921ab49444885R92-R95
   
   It is complaining about some of the types in this new method `translateDeprecatedConfigs` from here: https://github.com/apache/kafka/blob/f46d4f4fce341326c06c0aa8b2d0d64982573658/clients/src/main/java/org/apache/kafka/common/utils/ConfigUtils.java#L51
   
   Not sure if this is something you were already aware or if there is really an issue here? but I just thought to mention!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org