[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1657: MINIFICPP-2207 HttpRequestMethod should be an enum

["szaszm (via GitHub)" <gi...@apache.org>]

szaszm commented on code in PR #1657:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1657#discussion_r1324586907


##########
libminifi/include/utils/BaseHTTPClient.h:
##########
@@ -178,6 +178,12 @@ namespace HTTPRequestResponse {
   int seek_callback(void *p, int64_t offset, int);
 }
 
+#undef DELETE  // this is a macro in winnt.h

Review Comment:
   I think this should be `#undef`-ed nearest to the source, in the file that includes `winnt.h`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org