You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/18 07:55:51 UTC
[GitHub] [iotdb] yifuzhou opened a new pull request #2868: simplify the Avg formula on removing redundant operations
yifuzhou opened a new pull request #2868:
URL: https://github.com/apache/iotdb/pull/2868
## Description
I did serval improvements of the AVG function:
The formula to calculate AVG function is complex, it can be simplified. I removed reduncdant operations.
When we calculate the AVG, the result value will transfer into Double type. in Java, the calculation of double type will always cause the loss of accuracy. And in our test case, there are lots of values which are loss of accuracy. I try to fix it by using assertEquals(double expected, double actual, double delta)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] yifuzhou commented on pull request #2868: simplify the Avg formula on removing redundant operations
Posted by GitBox <gi...@apache.org>.
yifuzhou commented on pull request #2868:
URL: https://github.com/apache/iotdb/pull/2868#issuecomment-802667768
> There are some tests failed. Please take a look...
Thanks HTHou. Yes, I have already fixed it but it still has a weird fail test case. Last time I saw it and just rerun ci again without any change and it pass...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #2868: simplify the Avg formula on removing redundant operations
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #2868:
URL: https://github.com/apache/iotdb/pull/2868#issuecomment-802430529
There are some tests failed. Please take a look...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LebronAl merged pull request #2868: simplify the Avg formula on removing redundant operations
Posted by GitBox <gi...@apache.org>.
LebronAl merged pull request #2868:
URL: https://github.com/apache/iotdb/pull/2868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org