You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by qi...@apache.org on 2022/04/14 06:12:55 UTC
[iotdb] branch master updated: fix NPE when stop IoTDB and MLogTxtWriter parsing CreateAlignedTimeseriesPlan error (#5525)
This is an automated email from the ASF dual-hosted git repository.
qiaojialin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/master by this push:
new 07a407be6f fix NPE when stop IoTDB and MLogTxtWriter parsing CreateAlignedTimeseriesPlan error (#5525)
07a407be6f is described below
commit 07a407be6feb7c2f777c80cd9e7872fd4e98f968
Author: Marcos_Zyk <38...@users.noreply.github.com>
AuthorDate: Thu Apr 14 14:12:50 2022 +0800
fix NPE when stop IoTDB and MLogTxtWriter parsing CreateAlignedTimeseriesPlan error (#5525)
---
.../org/apache/iotdb/db/metadata/logfile/MLogTxtWriter.java | 11 +++++++----
.../java/org/apache/iotdb/db/service/IoTDBShutdownHook.java | 6 +-----
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/server/src/main/java/org/apache/iotdb/db/metadata/logfile/MLogTxtWriter.java b/server/src/main/java/org/apache/iotdb/db/metadata/logfile/MLogTxtWriter.java
index f4b85f95ba..c9660562df 100644
--- a/server/src/main/java/org/apache/iotdb/db/metadata/logfile/MLogTxtWriter.java
+++ b/server/src/main/java/org/apache/iotdb/db/metadata/logfile/MLogTxtWriter.java
@@ -58,6 +58,7 @@ import java.nio.file.Paths;
import java.util.List;
import java.util.Map;
import java.util.concurrent.atomic.AtomicInteger;
+import java.util.stream.Collectors;
public class MLogTxtWriter implements AutoCloseable {
@@ -140,12 +141,14 @@ public class MLogTxtWriter implements AutoCloseable {
buf.append(
String.format(
"%s,%s,%s,%s,%s,%s",
- MetadataOperationType.CREATE_TIMESERIES,
+ MetadataOperationType.CREATE_ALIGNED_TIMESERIES,
plan.getPrefixPath().getFullPath(),
plan.getMeasurements(),
- plan.getDataTypes().stream().map(TSDataType::serialize),
- plan.getEncodings().stream().map(TSEncoding::serialize),
- plan.getCompressors().stream().map(CompressionType::serialize)));
+ plan.getDataTypes().stream().map(TSDataType::serialize).collect(Collectors.toList()),
+ plan.getEncodings().stream().map(TSEncoding::serialize).collect(Collectors.toList()),
+ plan.getCompressors().stream()
+ .map(CompressionType::serialize)
+ .collect(Collectors.toList())));
buf.append(",[");
if (plan.getAliasList() != null) {
diff --git a/server/src/main/java/org/apache/iotdb/db/service/IoTDBShutdownHook.java b/server/src/main/java/org/apache/iotdb/db/service/IoTDBShutdownHook.java
index dd7554a3cf..270c3d1935 100644
--- a/server/src/main/java/org/apache/iotdb/db/service/IoTDBShutdownHook.java
+++ b/server/src/main/java/org/apache/iotdb/db/service/IoTDBShutdownHook.java
@@ -18,8 +18,6 @@
*/
package org.apache.iotdb.db.service;
-import org.apache.iotdb.db.metadata.schemaregion.ISchemaRegion;
-import org.apache.iotdb.db.metadata.schemaregion.SchemaEngine;
import org.apache.iotdb.db.utils.MemUtils;
import org.slf4j.Logger;
@@ -32,9 +30,7 @@ public class IoTDBShutdownHook extends Thread {
@Override
public void run() {
// close rocksdb if possible to avoid lose data
- for (ISchemaRegion schemaRegion : SchemaEngine.getInstance().getAllSchemaRegions()) {
- schemaRegion.clear();
- }
+ IoTDB.configManager.clear();
if (logger.isInfoEnabled()) {
logger.info(
"IoTDB exits. Jvm memory usage: {}",