You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/04/21 15:33:25 UTC
[GitHub] [fineract] ptuomola opened a new pull request, #2289: Moving SonarCloud to GitHub Actions
ptuomola opened a new pull request, #2289:
URL: https://github.com/apache/fineract/pull/2289
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] sonarcloud[bot] commented on pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #2289:
URL: https://github.com/apache/fineract/pull/2289#issuecomment-1107147464
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_fineract&pullRequest=2289)
[](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_fineract&pullRequest=2289&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_fineract&pullRequest=2289&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_fineract&pullRequest=2289&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_fineract&pullRequest=2289&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_fineract&pullRequest=2289&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_fineract&pullRequest=2289&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_fineract&pullRequest=2289&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] sonarcloud[bot] commented on pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #2289:
URL: https://github.com/apache/fineract/pull/2289#issuecomment-1107152279
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_fineract&pullRequest=2289)
[](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_fineract&pullRequest=2289&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_fineract&pullRequest=2289&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_fineract&pullRequest=2289&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_fineract&pullRequest=2289&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_fineract&pullRequest=2289&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2289:
URL: https://github.com/apache/fineract/pull/2289#discussion_r855862056
##########
.github/workflows/sonarqube.yml:
##########
@@ -9,11 +9,11 @@ jobs:
runs-on: ubuntu-20.04
env:
TZ: Asia/Kolkata
- SONAR_ORGANIZATION: ${{ secrets.SONAR_ORGANIZATION }}
- SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }}
- SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+ SONAR_ORGANIZATION: apache
Review Comment:
Yep, just used the CLI for it, here are the commands I did:
```
$ gh secret set SONAR_PROJECT_KEY -b "apache"
✓ Set Actions secret SONAR_PROJECT_KEY for apache/fineract
$ gh secret set SONAR_PROJECT_KEY -b "apache_fineract"
✓ Set Actions secret SONAR_PROJECT_KEY for apache/fineract
$ gh secret set SONAR_HOST_URL -b "https://sonarcloud.io"
✓ Set Actions secret SONAR_HOST_URL for apache/fineract
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2289:
URL: https://github.com/apache/fineract/pull/2289#discussion_r855812788
##########
.github/workflows/sonarqube.yml:
##########
@@ -9,11 +9,11 @@ jobs:
runs-on: ubuntu-20.04
env:
TZ: Asia/Kolkata
- SONAR_ORGANIZATION: ${{ secrets.SONAR_ORGANIZATION }}
- SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }}
- SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+ SONAR_ORGANIZATION: apache
Review Comment:
Petri, do you think we could extract these env variables into GH secrets?
The reason it would be really useful is because there are forks out there which gets regularly synced from this repo and all those forks could also utilize their own sonar instance for checks just by reconfiguring their secrets instead of changing the workflow code.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2289:
URL: https://github.com/apache/fineract/pull/2289#discussion_r855854727
##########
.github/workflows/sonarqube.yml:
##########
@@ -9,11 +9,11 @@ jobs:
runs-on: ubuntu-20.04
env:
TZ: Asia/Kolkata
- SONAR_ORGANIZATION: ${{ secrets.SONAR_ORGANIZATION }}
- SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }}
- SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+ SONAR_ORGANIZATION: apache
Review Comment:
Sounds good, let me do it and get back to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on a diff in pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
ptuomola commented on code in PR #2289:
URL: https://github.com/apache/fineract/pull/2289#discussion_r855850169
##########
.github/workflows/sonarqube.yml:
##########
@@ -9,11 +9,11 @@ jobs:
runs-on: ubuntu-20.04
env:
TZ: Asia/Kolkata
- SONAR_ORGANIZATION: ${{ secrets.SONAR_ORGANIZATION }}
- SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }}
- SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+ SONAR_ORGANIZATION: apache
Review Comment:
Hi - we don't have the rights to add secrets to our repo as it is owned by Apache. @vorburger worked out the process to get secrets added using the REST API - you can find the description here (last paragraph): http://blog2.vorburger.ch/2020/05/fineractdev-cicd-from-github-to-google.html?m=1
I haven't tried this, but if you want to give it a go - then by all means go for it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
vidakovic merged PR #2289:
URL: https://github.com/apache/fineract/pull/2289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #2289: Moving SonarCloud to GitHub Actions
URL: https://github.com/apache/fineract/pull/2289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] sonarcloud[bot] commented on pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #2289:
URL: https://github.com/apache/fineract/pull/2289#issuecomment-1105450751
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_fineract&pullRequest=2289)
[](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_fineract&pullRequest=2289&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_fineract&pullRequest=2289&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_fineract&pullRequest=2289&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_fineract&pullRequest=2289&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_fineract&pullRequest=2289&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_fineract&pullRequest=2289&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on a diff in pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
ptuomola commented on code in PR #2289:
URL: https://github.com/apache/fineract/pull/2289#discussion_r855859697
##########
.github/workflows/sonarqube.yml:
##########
@@ -9,11 +9,11 @@ jobs:
runs-on: ubuntu-20.04
env:
TZ: Asia/Kolkata
- SONAR_ORGANIZATION: ${{ secrets.SONAR_ORGANIZATION }}
- SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }}
- SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+ SONAR_ORGANIZATION: apache
Review Comment:
Except it might now be even easier at it seems they've added secrets support to the gh cli: https://github.com/cli/cli/releases/tag/v1.4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2289:
URL: https://github.com/apache/fineract/pull/2289#discussion_r855862518
##########
.github/workflows/sonarqube.yml:
##########
@@ -9,11 +9,11 @@ jobs:
runs-on: ubuntu-20.04
env:
TZ: Asia/Kolkata
- SONAR_ORGANIZATION: ${{ secrets.SONAR_ORGANIZATION }}
- SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }}
- SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+ SONAR_ORGANIZATION: apache
Review Comment:
Do you mind switching these back to secrets so we can try it? Hopefully that should be it and we can get rid of the travis build completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on a diff in pull request #2289: Moving SonarCloud to GitHub Actions
Posted by GitBox <gi...@apache.org>.
ptuomola commented on code in PR #2289:
URL: https://github.com/apache/fineract/pull/2289#discussion_r856751940
##########
.github/workflows/sonarqube.yml:
##########
@@ -9,11 +9,11 @@ jobs:
runs-on: ubuntu-20.04
env:
TZ: Asia/Kolkata
- SONAR_ORGANIZATION: ${{ secrets.SONAR_ORGANIZATION }}
- SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }}
- SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+ SONAR_ORGANIZATION: apache
Review Comment:
Ok - done. Seems to work - can you have a look and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org