[GitHub] [beam] ElessarST commented on a change in pull request #16061: [BEAM-13428] [Playground] Integrate Google Analytics

[GitBox <gi...@apache.org>]

ElessarST commented on a change in pull request #16061:
URL: https://github.com/apache/beam/pull/16061#discussion_r760412267



##########
File path: playground/frontend/lib/pages/playground/components/playground_feedback.dart
##########
@@ -37,14 +38,20 @@ class PlaygroundFeedback extends StatelessWidget {
         ),
         IconButton(
           padding: EdgeInsets.zero,
-          // ignore: avoid_print
-          onPressed: () => print('Feedback Up'),
+          onPressed: () {
+            AnalyticsService.get(context).trackClickEnjoyPlayground(true);
+            // ignore: avoid_print
+            print('Feedback Up');

Review comment:
       Yes, I added a safe send event for Analytics Service and removed all prints.

##########
File path: playground/frontend/lib/pages/playground/components/playground_feedback.dart
##########
@@ -37,14 +38,20 @@ class PlaygroundFeedback extends StatelessWidget {
         ),
         IconButton(
           padding: EdgeInsets.zero,
-          // ignore: avoid_print
-          onPressed: () => print('Feedback Up'),
+          onPressed: () {
+            AnalyticsService.get(context).trackClickEnjoyPlayground(true);
+            // ignore: avoid_print
+            print('Feedback Up');
+          },
           icon: SvgPicture.asset(kThumbUpIconAsset),
         ),
         IconButton(
           padding: EdgeInsets.zero,
-          // ignore: avoid_print
-          onPressed: () => print('Feedback down'),
+          onPressed: () {
+            AnalyticsService.get(context).trackClickEnjoyPlayground(false);
+            // ignore: avoid_print
+            print('Feedback down');

Review comment:
       same here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org