You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/24 23:51:14 UTC
[GitHub] [fineract] thesmallstar opened a new pull request #933: FINERACT-821 Added multiple checkstyles
thesmallstar opened a new pull request #933:
URL: https://github.com/apache/fineract/pull/933
I feel sorry for someone who have to look and consider this PR, but anyways.
So I came across this extremely cool repo: https://github.com/google/google-java-format
It formats java code according to google checkstyles(it is by google).
It made out code look nicer, and helped implement some of the hardest to implement checkstyles otherwise(Even with plugins).
Definitely not necessary to merge this, but what do you feel about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #933: FINERACT-821 Added multiple checkstyles
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #933:
URL: https://github.com/apache/fineract/pull/933#issuecomment-633318871
@vorburger even if this looks good(highly unlikely :P), I will make a separate PR for each checkstyle :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #933: FINERACT-821 Added multiple checkstyles
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #933:
URL: https://github.com/apache/fineract/pull/933#issuecomment-633886410
> Definitely not necessary to merge this, but what do you feel about it?
I've opened new FINERACT-1006 for further discussion about the general topic of "Code Auto Formatting" which is what you are basically exploring here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #933: FINERACT-821 Added multiple checkstyles
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #933:
URL: https://github.com/apache/fineract/pull/933#issuecomment-633322878
Tests failed due to "Connection reset", closing and opening the PR again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #933: FINERACT-821 Added multiple checkstyles
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #933:
URL: https://github.com/apache/fineract/pull/933#issuecomment-634940232
Progress here: #943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar closed pull request #933: FINERACT-821 Added multiple checkstyles
Posted by GitBox <gi...@apache.org>.
thesmallstar closed pull request #933:
URL: https://github.com/apache/fineract/pull/933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar closed pull request #933: FINERACT-821 Added multiple checkstyles
Posted by GitBox <gi...@apache.org>.
thesmallstar closed pull request #933:
URL: https://github.com/apache/fineract/pull/933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org