[jira] [Commented] (HBASE-22605) Ref guide includes dev guidance only applicable to EOM versions

["HBase QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868530#comment-16868530 ] 

HBase QA commented on HBASE-22605:
----------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m  2s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 11m 31s{color} | {color:blue} branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue}  7m 11s{color} | {color:blue} patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 43s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/PreCommit-HBASE-Build/560/artifact/patchprocess/Dockerfile |
| JIRA Issue | HBASE-22605 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12972247/HBASE-22605.000.patch |
| Optional Tests |  dupname  asflicense  refguide  |
| uname | Linux 9763255e7174 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c7c6140396 |
| maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| refguide | https://builds.apache.org/job/PreCommit-HBASE-Build/560/artifact/patchprocess/branch-site/book.html |
| refguide | https://builds.apache.org/job/PreCommit-HBASE-Build/560/artifact/patchprocess/patch-site/book.html |
| Max. process+thread count | 95 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/560/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> Ref guide includes dev guidance only applicable to EOM versions
> ---------------------------------------------------------------
>
>                 Key: HBASE-22605
>                 URL: https://issues.apache.org/jira/browse/HBASE-22605
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Sean Busbey
>            Assignee: Mingliang Liu
>            Priority: Trivial
>              Labels: beginner
>         Attachments: HBASE-22605.000.patch
>
>
> The ref guide section on developer guidance has this blurb:
> {quote}
> h2. Implementing Writable
> h3. Applies pre-0.96 only
> bq. In 0.96, HBase moved to protocol buffers (protobufs). The below section on Writables applies to 0.94.x and previous, not to 0.96 and beyond.
> Every class returned by RegionServers must implement the Writable interface. If you are creating a new class that needs to implement this interface, do not forget the default constructor.
> {quote}
> ([ref|http://hbase.apache.org/book.html#common.patch.feedback.writable])
> this should be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)