[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671819#comment-16671819 ] 

ASF GitHub Bot commented on FLINK-10715:
----------------------------------------

igalshilman opened a new pull request #6996: [FLINK-10715] Change reporter log level
URL: https://github.com/apache/flink/pull/6996
 
 
   ## What is the purpose of the change
   
   Metric reporters might periodically fail due to transient errors downstream, therefore they should not pollute the log with the full stack trace (unless debug is enabled)
   
   ## Brief change log
   
     - `MetricRegistryImpl` now logs reports failure without the stack trace. (unless log level is debug)
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / *no*)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / *no*)
     - The serializers: (yes / *no* / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / *no* / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / *no* / don't know)
     - The S3 file system connector: (yes / *no* / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / *no*)
     - If yes, how is the feature documented? (*not applicable* / docs / JavaDocs / not documented)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> E2e tests fail with ConcurrentModificationException in MetricRegistryImpl
> -------------------------------------------------------------------------
>
>                 Key: FLINK-10715
>                 URL: https://issues.apache.org/jira/browse/FLINK-10715
>             Project: Flink
>          Issue Type: Bug
>          Components: E2E Tests, Metrics
>    Affects Versions: 1.7.0
>            Reporter: Dawid Wysakowicz
>            Assignee: Igal Shilman
>            Priority: Blocker
>              Labels: pull-request-available
>
> Couple of e2e tests that rely on metrics fail with exception:
> {code}
> 2018-10-29 11:40:32,781 WARN  org.apache.flink.runtime.metrics.MetricRegistryImpl           - Error while reporting metrics
> java.util.ConcurrentModificationException
> 	at java.util.HashMap$HashIterator.nextNode(HashMap.java:1437)
> 	at java.util.HashMap$EntryIterator.next(HashMap.java:1471)
> 	at java.util.HashMap$EntryIterator.next(HashMap.java:1469)
> 	at org.apache.flink.metrics.slf4j.Slf4jReporter.report(Slf4jReporter.java:101)
> 	at org.apache.flink.runtime.metrics.MetricRegistryImpl$ReporterTask.run(MetricRegistryImpl.java:427)
> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 	at java.lang.Thread.run(Thread.java:748)
> {code}
> Tests that failed:
> *  'Resuming Externalized Checkpoint (file, sync, no parallelism change) end-to-end test
> * 'State TTL Heap backend end-to-end test'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)