You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Karan Mehta (JIRA)" <ji...@apache.org> on 2018/10/24 03:45:00 UTC

[jira] [Commented] (PHOENIX-4981) Add tests for ORDER BY, GROUP BY, salted tables using phoenix-spark

    [ https://issues.apache.org/jira/browse/PHOENIX-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661685#comment-16661685 ] 

Karan Mehta commented on PHOENIX-4981:
--------------------------------------

[~tdsilva] It would be good to put it up as Github PR.

Just one comment for now SparkUtil#SparkContext INSTANCE double checked locking is broken. The singleton should be volatile.

Check: [https://javarevisited.blogspot.com/2014/05/double-checked-locking-on-singleton-in-java.html]

> Add tests for ORDER BY, GROUP BY, salted tables using phoenix-spark
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-4981
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4981
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>              Labels: spark
>         Attachments: PHOENIX-4981-4.x-HBase-1.3.patch
>
>
> See if its possible to reuse {{SaltedTableIT}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)