You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/09/02 19:23:22 UTC

[GitHub] [trafficserver] randall commented on a change in pull request #7157: rc: fixes systemd unit file stopping

randall commented on a change in pull request #7157:
URL: https://github.com/apache/trafficserver/pull/7157#discussion_r482332479



##########
File path: rc/trafficserver.service.in
##########
@@ -27,8 +27,8 @@ Restart=on-failure
 RestartSec=5s
 LimitNOFILE=1000000
 ExecStopPost=/bin/sh -c ' \
-        export TM_PIDFILE=$(@exp_bindir@/traffic_layout} 2>/dev/null | grep RUNTIMEDIR | cut -d: -f2)/manager.lock ; \
-        /bin/rm -f $TM_PIDFILE ; \

Review comment:
       We want the non-zero status code. I think we assume that ATS started up correctly in the first place.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org