[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11083: feat: custom favorite filter for dashboards, charts and saved queries

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #11083:
URL: https://github.com/apache/incubator-superset/pull/11083#discussion_r498154483



##########
File path: tests/queries/saved_queries/api_tests.py
##########
@@ -326,17 +326,22 @@ def test_get_saved_query_favorite_filter(self):
         self.login(username="admin")
         uri = f"api/v1/saved_query/?q={prison.dumps(arguments)}"
         rv = self.client.get(uri)
-        self.assertEqual(rv.status_code, 200)
         data = json.loads(rv.data.decode("utf-8"))
-        self.assertEqual(data["count"], len(expected_models))
+        assert rv.status_code == 200

Review comment:
       Because it's used nowhere on the test codebase, not written in stone but with `pytest` now we are inclined to use `assert`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org