[GitHub] [pulsar] tuteng commented on a change in pull request #5897: [Issue 5887]Fix old version download link error

[GitBox <gi...@apache.org>]

tuteng commented on a change in pull request #5897: [Issue 5887]Fix old version download link error
URL: https://github.com/apache/pulsar/pull/5897#discussion_r361564995
 
 

 ##########
 File path: site2/website/scripts/replace.js
 ##########
 @@ -178,13 +178,20 @@ for (v of versions) {
       `${v}`,
       binaryReleaseUrl(`${v}`),
       connectorReleaseUrl(`${v}`),
-      prestoPulsarReleaseUrl(`${latestVersion}`),
+      offloaderReleaseUrl(`${v}`),
+      prestoPulsarReleaseUrl(`${v}`),
       downloadPageUrl(),
       rpmReleaseUrl(`${v}`, ""),
       rpmReleaseUrl(`${v}`, "-debuginfo"),
       rpmReleaseUrl(`${v}`, "-devel"),
       debReleaseUrl(`${v}`, ""),
       debReleaseUrl(`${v}`, "-dev"),
+
+      rpmDistUrl(`${v}`, ""),
+      rpmDistUrl(`${v}`, "-debuginfo"),
+      rpmDistUrl(`${v}`, "-devel"),
+      debDistUrl(`${v}`, ""),
+      debDistUrl(`${v}`, "-dev")
 
 Review comment:
   You can try:
   
   ```
         `${vWithoutIncubating}`,
         `${v}`,
         binaryReleaseUrl(`${v}`),
         connectorReleaseUrl(`${v}`),
         offloaderReleaseUrl(`${v}`),
         prestoPulsarReleaseUrl(`${v}`),
         downloadPageUrl(),
         rpmDistUrl(`${v}`, ""),
         rpmDistUrl(`${v}`, "-debuginfo"),
         rpmDistUrl(`${v}`, "-devel"),
         debDistUrl(`${v}`, ""),
         debDistUrl(`${v}`, "-dev"),
         rpmDistUrl(`${v}`, ""),
         rpmDistUrl(`${v}`, "-debuginfo"),
         rpmDistUrl(`${v}`, "-devel"),
         debDistUrl(`${v}`, ""),
         debDistUrl(`${v}`, "-dev")
   ```
   You can test the results by opening the html file `build/pulsar/docs/en/2.4.1/client-libraries-cpp/index.html` through the browser. I think this is correct.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services