Re: [PR] [Bugfix] Fix getting system environment variables error [paimon-webui]

["hdygxsj (via GitHub)" <gi...@apache.org>]

hdygxsj commented on code in PR #521:
URL: https://github.com/apache/paimon-webui/pull/521#discussion_r1715313234


##########
paimon-web-server/src/main/bin/start.sh:
##########
@@ -64,12 +64,18 @@ fi
 if [ -z "$JAVA_HOME" ]; then
       echo "JAVA_HOME is null, exit..."
       exit 1
+else
+   export JAVA_HOME=$JAVA_HOME
 fi
 if [ -z "$FLINK_HOME" ]; then
     echo "FLINK_HOME is null, CDC cannot be used normally!"
+else
+    export FLINK_HOME=$FLINK_HOME
 fi
 if [ -z "$ACTION_JAR_PATH" ]; then
     echo "ACTION_JAR_PATH is null, CDC cannot be used normally!"
+else
+    export ACTION_JAR_PATH=$ACTION_JAR_PATH

Review Comment:
   please change ACTION_JAR_PATH= to ACTION_JAR_PATH=${ACTION_JAR_PATH:-""}   in env.sh to avoid 
   the env ACTION_JAR_PATH be covered



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org