You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/01 16:57:43 UTC
[GitHub] [tvm] Lunderberg opened a new pull request #8904: [Vulkan][Topi] Parametrizing additional topi tests, marking vulkan failures
Lunderberg opened a new pull request #8904:
URL: https://github.com/apache/tvm/pull/8904
This PR aims to make the unit test suite run with `TVM_TEST_TARGETS="vulkan -from_device=0"`. This PR applies a few minor fixes, parametrizes several topi unit tests that were previously failing, and marks the specific failing cases with xfail. The failing cases will be tracked in https://github.com/apache/tvm/issues/8903.
[UnitTest][Topi] Parametrized several unit tests, identify vulkan failures
- Parametrized topi modules
- test_topi_conv1d_transpose_ncw.py
- test_topi_conv2d_nhwc.py
- test_topi_correlation.py
- test_topi_loss.py
- test_topi_math.py
- test_topi_reduce.py
- test_topi_softmax.py
- test_topi_sort.py
- test_topi_unique.py
- test_topi_vision.py
- Unit Tests fixed
- `test_topi_loss::test_nll_loss`, failure due to `supports_float64` not being passed from the target to the codegen.
- Known Vulkan failures (tracked in https://github.com/apache/tvm/issues/8903)
- test_topi_math.py::test_ewise, ["tan", "erf", "isnan", "isfinite", "isinf"]
Unimplemented CallNode operations
- test_topi_reduce.py::test_reduce_map, ["sum", "any", "all"]
Fails during codegen, unexpected size of data type.
- test_topi_vision.py::test_proposal
Marked test_proposal as xfail on vulkan, currently has a type error between bool/int8.
- test_topi_conv1d_transpose_ncw.py::test_conv1d_transpose_ncw
Incorrect numeric output, a few elements outside of allowed tolerance, only occurs on vulkan backend.
- test_softmax.py::test_softmax
Marked float64 operations as xfail in vulkan, because GLSL.std.450 only supports 16/32-bit floats.
[UnitTests][Vulkan] Improved robustness of test_tir_intrin::test_clz
Previously, would fail during build since support for Int64 primitives wasn't declared in the `"vulkan"` target. Now, uses `"vulkan -from_device=0"` target and marks the test as xfail if the current target doesn't support Int64.
[Pytest] Fixed TestTargetAutoParametrization in cases where LLVM is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #8904: [Vulkan][Topi] Parametrizing additional topi tests, marking vulkan failures
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8904:
URL: https://github.com/apache/tvm/pull/8904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a change in pull request #8904: [Vulkan][Topi] Parametrizing additional topi tests, marking vulkan failures
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on a change in pull request #8904:
URL: https://github.com/apache/tvm/pull/8904#discussion_r700556720
##########
File path: tests/python/topi/python/test_topi_loss.py
##########
@@ -56,15 +64,15 @@ def verify_nll_loss(
tvm.testing.assert_allclose(out_topi, out_npy, rtol=1e-4, atol=1e-5)
-@tvm.testing.parametrize_targets
-def test_nll_loss(dev, target):
- verify_nll_loss(dev, target, (10, 5))
- verify_nll_loss(dev, target, (10, 5, 2, 2))
- verify_nll_loss(dev, target, (10, 5), reduction="sum")
- verify_nll_loss(dev, target, (10, 5), reduction="none")
- verify_nll_loss(dev, target, (10, 5), ignore_index=3)
- verify_nll_loss(dev, target, (10, 5), dtype="float64")
+# @tvm.testing.parametrize_targets
+# def test_nll_loss(dev, target):
+# verify_nll_loss(dev, target, (10, 5))
+# verify_nll_loss(dev, target, (10, 5, 2, 2))
+# verify_nll_loss(dev, target, (10, 5), reduction="sum")
+# verify_nll_loss(dev, target, (10, 5), reduction="none")
+# verify_nll_loss(dev, target, (10, 5), ignore_index=3)
+# verify_nll_loss(dev, target, (10, 5), dtype="float64")
Review comment:
Whoops, those should have been removed entirely. Thank you for the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on a change in pull request #8904: [Vulkan][Topi] Parametrizing additional topi tests, marking vulkan failures
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #8904:
URL: https://github.com/apache/tvm/pull/8904#discussion_r700548205
##########
File path: tests/python/topi/python/test_topi_loss.py
##########
@@ -56,15 +64,15 @@ def verify_nll_loss(
tvm.testing.assert_allclose(out_topi, out_npy, rtol=1e-4, atol=1e-5)
-@tvm.testing.parametrize_targets
-def test_nll_loss(dev, target):
- verify_nll_loss(dev, target, (10, 5))
- verify_nll_loss(dev, target, (10, 5, 2, 2))
- verify_nll_loss(dev, target, (10, 5), reduction="sum")
- verify_nll_loss(dev, target, (10, 5), reduction="none")
- verify_nll_loss(dev, target, (10, 5), ignore_index=3)
- verify_nll_loss(dev, target, (10, 5), dtype="float64")
+# @tvm.testing.parametrize_targets
+# def test_nll_loss(dev, target):
+# verify_nll_loss(dev, target, (10, 5))
+# verify_nll_loss(dev, target, (10, 5, 2, 2))
+# verify_nll_loss(dev, target, (10, 5), reduction="sum")
+# verify_nll_loss(dev, target, (10, 5), reduction="none")
+# verify_nll_loss(dev, target, (10, 5), ignore_index=3)
+# verify_nll_loss(dev, target, (10, 5), dtype="float64")
Review comment:
Maybe delete these instead? Or mark them as known failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #8904: [Vulkan][Topi] Parametrizing additional topi tests, marking vulkan failures
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8904:
URL: https://github.com/apache/tvm/pull/8904#issuecomment-911356192
Thanks @Lunderberg @tkonolige
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org