You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2008/10/23 07:10:44 UTC
[jira] Created: (HAMA-89) [Shell] Exception Handling
[Shell] Exception Handling
---------------------------
Key: HAMA-89
URL: https://issues.apache.org/jira/browse/HAMA-89
Project: Hama
Issue Type: Improvement
Components: shell
Reporter: Edward J. Yoon
Fix For: 0.1.0
Hama > exit
org.apache.hama.shell.parser.script.ParseException: Encountered "exit" at line 3, column 1.
Was expecting one of:
<EOF>
"help" ...
"quit" ...
"" ...
<EOL> ...
It would be nice if shell shows simple guide instead of error message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-89) [Shell] Exception Handling
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-89:
---------------------------
Status: Patch Available (was: Open)
> [Shell] Exception Handling
> ---------------------------
>
> Key: HAMA-89
> URL: https://issues.apache.org/jira/browse/HAMA-89
> Project: Hama
> Issue Type: Improvement
> Components: shell
> Reporter: Edward J. Yoon
> Assignee: Samuel Guo
> Fix For: 0.1.0
>
> Attachments: HAMA-89.patch, HAMA-89_v01.patch
>
>
> Hama > exit
> org.apache.hama.shell.parser.script.ParseException: Encountered "exit" at line 3, column 1.
> Was expecting one of:
> <EOF>
> "help" ...
> "quit" ...
> "" ...
> <EOL> ...
> It would be nice if shell shows simple guide instead of error message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-89) [Shell] Exception Handling
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642112#action_12642112 ]
Edward J. Yoon commented on HAMA-89:
------------------------------------
Here's few comments
- There is a typing error. 'HBase Shell' should be 'Hama Shell'
- Let's hide a ParseException error message for easy-to-read using try/catch.
----
Hama > asdfsd
org.apache.hama.shell.parser.script.ParseException: Encountered "asdfsd" at line 2, column 1.
Was expecting one of:
<EOF>
"help" ...
"quit" ...
"" ...
<EOL> ...
HAMA V1.0 SHELL COMMANDS
all the supported commands in hama shell will be:
'<hama expression> ;',
'quit',
'help'.
Try type 'help' to see details.
Hama >
> [Shell] Exception Handling
> ---------------------------
>
> Key: HAMA-89
> URL: https://issues.apache.org/jira/browse/HAMA-89
> Project: Hama
> Issue Type: Improvement
> Components: shell
> Reporter: Edward J. Yoon
> Assignee: Samuel Guo
> Fix For: 0.1.0
>
> Attachments: HAMA-89.patch
>
>
> Hama > exit
> org.apache.hama.shell.parser.script.ParseException: Encountered "exit" at line 3, column 1.
> Was expecting one of:
> <EOF>
> "help" ...
> "quit" ...
> "" ...
> <EOL> ...
> It would be nice if shell shows simple guide instead of error message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-89) [Shell] Exception Handling
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-89:
---------------------------
Attachment: HAMA-89.patch
> [Shell] Exception Handling
> ---------------------------
>
> Key: HAMA-89
> URL: https://issues.apache.org/jira/browse/HAMA-89
> Project: Hama
> Issue Type: Improvement
> Components: shell
> Reporter: Edward J. Yoon
> Fix For: 0.1.0
>
> Attachments: HAMA-89.patch
>
>
> Hama > exit
> org.apache.hama.shell.parser.script.ParseException: Encountered "exit" at line 3, column 1.
> Was expecting one of:
> <EOF>
> "help" ...
> "quit" ...
> "" ...
> <EOL> ...
> It would be nice if shell shows simple guide instead of error message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-89) [Shell] Exception Handling
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-89:
---------------------------
Attachment: HAMA-89_v01.patch
try again.
> [Shell] Exception Handling
> ---------------------------
>
> Key: HAMA-89
> URL: https://issues.apache.org/jira/browse/HAMA-89
> Project: Hama
> Issue Type: Improvement
> Components: shell
> Reporter: Edward J. Yoon
> Assignee: Samuel Guo
> Fix For: 0.1.0
>
> Attachments: HAMA-89.patch, HAMA-89_v01.patch
>
>
> Hama > exit
> org.apache.hama.shell.parser.script.ParseException: Encountered "exit" at line 3, column 1.
> Was expecting one of:
> <EOF>
> "help" ...
> "quit" ...
> "" ...
> <EOL> ...
> It would be nice if shell shows simple guide instead of error message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-89) [Shell] Exception Handling
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-89:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Looks good. +1
BTW, Please comment the changes in patch.
Local test passed. I just committed this.
----
test:
[junit] Running org.apache.hama.TestDenseMatrix
[junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 59.625 sec
[junit] Running org.apache.hama.TestDenseVector
[junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 26.986 sec
[junit] Running org.apache.hama.io.TestBlockID
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.011 sec
[junit] Running org.apache.hama.mapred.TestMatrixMapReduce
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 55.322 sec
[junit] Running org.apache.hama.shell.parser.expression.TestHamaExpressionParser
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 107.697 sec
[junit] Running org.apache.hama.util.TestNumeric
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.018 sec
[junit] Running org.apache.hama.util.TestRandomVariable
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.017 sec
BUILD SUCCESSFUL
Total time: 4 minutes 36 seconds
> [Shell] Exception Handling
> ---------------------------
>
> Key: HAMA-89
> URL: https://issues.apache.org/jira/browse/HAMA-89
> Project: Hama
> Issue Type: Improvement
> Components: shell
> Reporter: Edward J. Yoon
> Assignee: Samuel Guo
> Fix For: 0.1.0
>
> Attachments: HAMA-89.patch, HAMA-89_v01.patch
>
>
> Hama > exit
> org.apache.hama.shell.parser.script.ParseException: Encountered "exit" at line 3, column 1.
> Was expecting one of:
> <EOF>
> "help" ...
> "quit" ...
> "" ...
> <EOL> ...
> It would be nice if shell shows simple guide instead of error message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-89) [Shell] Exception Handling
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-89:
---------------------------
Status: In Progress (was: Patch Available)
> [Shell] Exception Handling
> ---------------------------
>
> Key: HAMA-89
> URL: https://issues.apache.org/jira/browse/HAMA-89
> Project: Hama
> Issue Type: Improvement
> Components: shell
> Reporter: Edward J. Yoon
> Assignee: Samuel Guo
> Fix For: 0.1.0
>
> Attachments: HAMA-89.patch, HAMA-89_v01.patch
>
>
> Hama > exit
> org.apache.hama.shell.parser.script.ParseException: Encountered "exit" at line 3, column 1.
> Was expecting one of:
> <EOF>
> "help" ...
> "quit" ...
> "" ...
> <EOL> ...
> It would be nice if shell shows simple guide instead of error message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-89) [Shell] Exception Handling
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-89:
---------------------------
Assignee: Samuel Guo
Status: Patch Available (was: Open)
try it.
> [Shell] Exception Handling
> ---------------------------
>
> Key: HAMA-89
> URL: https://issues.apache.org/jira/browse/HAMA-89
> Project: Hama
> Issue Type: Improvement
> Components: shell
> Reporter: Edward J. Yoon
> Assignee: Samuel Guo
> Fix For: 0.1.0
>
> Attachments: HAMA-89.patch
>
>
> Hama > exit
> org.apache.hama.shell.parser.script.ParseException: Encountered "exit" at line 3, column 1.
> Was expecting one of:
> <EOF>
> "help" ...
> "quit" ...
> "" ...
> <EOL> ...
> It would be nice if shell shows simple guide instead of error message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.