You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:46:27 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #10462: style: make database list less bloated
mistercrunch opened a new pull request #10462:
URL: https://github.com/apache/incubator-superset/pull/10462
Late arriving cosmetic bash item:
<img width="1314" alt="Screen Shot 2020-07-28 at 11 19 06 PM" src="https://user-images.githubusercontent.com/487433/88763964-ef2fb680-d128-11ea-8c36-d26d35033f79.png">
<img width="1320" alt="Screen Shot 2020-07-28 at 11 16 56 PM" src="https://user-images.githubusercontent.com/487433/88763967-f060e380-d128-11ea-9f52-2bc950b87e1f.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10462: style: make database list less bloated
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10462:
URL: https://github.com/apache/incubator-superset/pull/10462#discussion_r462573781
##########
File path: superset/views/database/mixins.py
##########
@@ -197,7 +195,7 @@ class DatabaseMixin:
"extra": _("Extra"),
"encrypted_extra": _("Secure Extra"),
"server_cert": _("Root certificate"),
- "allow_run_async": _("Asynchronous Query Execution"),
+ "allow_run_async": _("Async Execution"),
Review comment:
I think the `#` here means that this was actually commented out at one point? I think there's something not set up quite right with the language packs... But there should be a script to run to pull in this new string into the translation packs. And then we could move the old string to the new one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10462: style: make database list less bloated
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10462:
URL: https://github.com/apache/incubator-superset/pull/10462#discussion_r462642449
##########
File path: superset/views/database/mixins.py
##########
@@ -197,7 +195,7 @@ class DatabaseMixin:
"extra": _("Extra"),
"encrypted_extra": _("Secure Extra"),
"server_cert": _("Root certificate"),
- "allow_run_async": _("Asynchronous Query Execution"),
+ "allow_run_async": _("Async Execution"),
Review comment:
Yeah we have bigger issues on `i18n`, the main one being that `superset-ui` doesn't get "inventorize" when scanning for new strings.
I tend to think of `i18n` as another parallel process that's not coupled to dev work. Technically we should re-publish the strings periodically, but not as part of everyday PRs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #10462: style: make database list less bloated
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #10462:
URL: https://github.com/apache/incubator-superset/pull/10462#discussion_r462082596
##########
File path: superset/views/database/mixins.py
##########
@@ -197,7 +195,7 @@ class DatabaseMixin:
"extra": _("Extra"),
"encrypted_extra": _("Secure Extra"),
"server_cert": _("Root certificate"),
- "allow_run_async": _("Asynchronous Query Execution"),
+ "allow_run_async": _("Async Execution"),
Review comment:
It appears this is translated in the ZH language pack: https://github.com/apache/incubator-superset/blob/c716f7afe8f528281950dea24f01c245690cad9e/superset/translations/zh/LC_MESSAGES/messages.po#L4031-L4032
Would be nice to change the reference so that the translation doesn't break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #10462: style: make database list less bloated
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10462:
URL: https://github.com/apache/incubator-superset/pull/10462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org