You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/01 01:11:23 UTC
[GitHub] [skywalking] wu-sheng opened a new issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
wu-sheng opened a new issue #6472:
URL: https://github.com/apache/skywalking/issues/6472
I am reviewing the core of OAP recently, one side to evaluate the requirements for the BanyanDB, and find the chance to improve the performance. #6411 is the first, this is the second one.
PersistenceTimer takes the core responsibility to assemble the requests and execute them to the storage. I noticed, the stage of assembly and execution is one-thread model. I remember these 2 stage causes many resources and latency. Considering the payload of OAP is usually not high, we could increase the number of thread to improve this.
@EvanLjp Could you share some stats data of self observability about these two?
FYI @apache/skywalking-committers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 edited a comment on issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
Posted by GitBox <gi...@apache.org>.
xuanyu66 edited a comment on issue #6472:
URL: https://github.com/apache/skywalking/issues/6472#issuecomment-809128234
@wu-sheng I want to konw, why metrics need to persist synchronously, can we just persist like record
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6472:
URL: https://github.com/apache/skywalking/issues/6472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6472:
URL: https://github.com/apache/skywalking/issues/6472#issuecomment-809135581
> @wu-sheng I want to konw, why metrics need to persist synchronously, can we just persist like record
Simple answer is, NO, they need to be in the sync way.. And we can't afford the load to explain how the source codes work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6472:
URL: https://github.com/apache/skywalking/issues/6472#issuecomment-798915245
@EvanLjp Back to you, have you tried to change `PersistenceTimer#extractDataAndSave`'s execution stage into the concurrency mode, such as using 2-4 threads to compare the performance? The 20s seem a little long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zifeihan edited a comment on issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
Posted by GitBox <gi...@apache.org>.
zifeihan edited a comment on issue #6472:
URL: https://github.com/apache/skywalking/issues/6472#issuecomment-809159923
@wu-sheng @xuanyu66 @EvanLjp I have also encountered the problem of es holding a lot of objects. in addition to multi-threaded writing, I also made an optimization here. I rewritten the buildBatchRequests method in MetricsPersistentWorker and added a parameter for batch writing. , Is to avoid frequent updates of hourly and day indicators. In addition, I made a time window to write one minute of data asynchronously (window period). If the current one minute has passed, then use synchronous writing. We have observed that the effect is good. hope some suggestions.
like this
```
public void buildBatchRequests(List<PrepareRequest> prepareRequests) {
if ((batchFactor == 0) || (Math.abs(batchCount.getAndAdd(1)) % batchFactor == 0)) {
prepareBatch(getCache().read(), prepareRequests);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on issue #6472:
URL: https://github.com/apache/skywalking/issues/6472#issuecomment-787933461


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zifeihan commented on issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
Posted by GitBox <gi...@apache.org>.
zifeihan commented on issue #6472:
URL: https://github.com/apache/skywalking/issues/6472#issuecomment-809159923
@wu-sheng @xuanyu66 @EvanLjp I have also encountered the problem of es holding a lot of objects. in addition to multi-threaded writing, I also made an optimization here. I rewritten the buildBatchRequests method in MetricsPersistentWorker and added a parameter for batch writing. , Is to avoid frequent updates of hourly and day indicators. In addition, I made a time window to write one minute of data asynchronously (window period). If the current one minute has passed, then use synchronous writing. We have observed that the effect is good. hope some suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on issue #6472:
URL: https://github.com/apache/skywalking/issues/6472#issuecomment-809128234
I want to konw, why metrics need to persist synchronously, can we just persist like record
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6472:
URL: https://github.com/apache/skywalking/issues/6472#issuecomment-809168537
I am not following the codes. Could you submit a real design with a test benchmark?
This is a part of core, if we want to change this, it should be evaluted and reviewed carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on issue #6472: Evaluate the possibility to make PersistenceTimer running in multi threads
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on issue #6472:
URL: https://github.com/apache/skywalking/issues/6472#issuecomment-798916750
let me have a try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org