You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/25 11:49:04 UTC

[GitHub] [camel-karavan] httpsOmkar opened a new pull request #124: removed package-lock.json

httpsOmkar opened a new pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124


   fixed the bug when we use the following yaml
   
   ```yaml
   apiVersion: camel.apache.org/v1
   kind: Integration
   metadata:
     name: SOME_INTEGRATION
   spec:
     flows:
       - from:
           parameters:
             subpath: SOME_PATH
           uri: 'kamelet:webhook-source'
           steps:
             - filter:
                 expression:
                   jsonpath:
                     expression: $.some.data.that.doesnt.exists
                     suppress-exceptions: true
                 steps:
                   - remove-headers:
                       pattern: '*'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] httpsOmkar commented on pull request #124: bug fix when expression is not string

Posted by GitBox <gi...@apache.org>.
httpsOmkar commented on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979196380


   can I implement it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] mgubaidullin edited a comment on pull request #124: bug fix when expression is not string

Posted by GitBox <gi...@apache.org>.
mgubaidullin edited a comment on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979189950


   Currently Karavan supports only implicit and explicit Expression definition. Ex. yaml for your case:
   ```
   apiVersion: camel.apache.org/v1
   kind: Integration
   metadata:
     name: jsonpath-test.yaml
   spec:
     flows:
       - from:
           uri: 'kamelet:webhook-source'
           steps:
             - filter:
                 expression:
                   jsonpath: $.some.data.that.doesnt.exists
             - remove-headers:
                 pattern: '*'
           parameters:
             subpath: SOME_PATH
   ```
   
   UI
   <img width="746" alt="Screen Shot 2021-11-25 at 7 45 49 AM" src="https://user-images.githubusercontent.com/1379213/143444545-ade09ff1-e557-49d2-a4f6-efed03bd4937.png">
   
   
   
   
   
   Full Expression definition is not yet implemented. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] oscerd commented on pull request #124: removed package-lock.json

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979165477


   Yes, but it's not related to the fix in the .tsx file. I think if it must be done, it should be in different commit. By the way wait for @mgubaidullin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] httpsOmkar commented on pull request #124: removed package-lock.json

Posted by GitBox <gi...@apache.org>.
httpsOmkar commented on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979165297


   It's not good practice to use different package managers. Let me know if we use only npm instead of yarn. I'll remove the yarn.lock instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] mgubaidullin closed pull request #124: bug fix when expression is not string

Posted by GitBox <gi...@apache.org>.
mgubaidullin closed pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] httpsOmkar commented on pull request #124: removed package-lock.json

Posted by GitBox <gi...@apache.org>.
httpsOmkar commented on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979163225


   I just removed the package-lock.json since the integrity of the packages is tracked in `yarn.lock` I assumed that the project is using a yarn by default. Since the other folder which is `karavan-designer` have only yarn.lock


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] httpsOmkar commented on pull request #124: removed package-lock.json

Posted by GitBox <gi...@apache.org>.
httpsOmkar commented on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979153984


   > I don't think it must be removed
   
   what should I remove?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] mgubaidullin commented on pull request #124: bug fix when expression is not string

Posted by GitBox <gi...@apache.org>.
mgubaidullin commented on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979217275


   @httpsOmkar yes, contributions are welcome. This one is quite complex (that's why it is not yet implemented 😉
   
   However, to make it work you'll need to create 
   1. Generator from `camel-yaml-dsl.json` to CamelModel, CamelAPI, CamelMetadata for all 21 expression languages
   2. Implement UI builder new Models in DslProperties
   3. Adjust CamelYaml to read/write all types (implicit/explicit/full expressions) correctly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] httpsOmkar commented on pull request #124: removed package-lock.json

Posted by GitBox <gi...@apache.org>.
httpsOmkar commented on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979173131


   I restored the package-lock.json


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] httpsOmkar commented on pull request #124: removed package-lock.json

Posted by GitBox <gi...@apache.org>.
httpsOmkar commented on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979166905


   Yeah, you are right. I'll address into different MR for the package-lock.json.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] oscerd commented on pull request #124: removed package-lock.json

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979159412


   You shouldn't remove package-lock.json and yarn.lock 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-karavan] mgubaidullin commented on pull request #124: bug fix when expression is not string

Posted by GitBox <gi...@apache.org>.
mgubaidullin commented on pull request #124:
URL: https://github.com/apache/camel-karavan/pull/124#issuecomment-979189950


   Currently Karavan supports only implicit and explicit Expression definition. Ex. yaml for your case:
   ```
   apiVersion: camel.apache.org/v1
   kind: Integration
   metadata:
     name: jsonpath-test.yaml
   spec:
     flows:
       - from:
           uri: 'kamelet:webhook-source'
           steps:
             - filter:
                 expression:
                   jsonpath: $.some.data.that.doesnt.exists
             - remove-headers:
                 pattern: '*'
           parameters:
             subpath: SOME_PATH
   ```
   
   UI
   <img width="746" alt="Screen Shot 2021-11-25 at 7 45 49 AM" src="https://user-images.githubusercontent.com/1379213/143444545-ade09ff1-e557-49d2-a4f6-efed03bd4937.png">
   
   
   Full Expression definition is not yet implemented. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org