[jira] [Commented] (OFBIZ-8462) Improvements in ShipmentItemBilling entity definition and services

["Rishi Solanki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079871#comment-16079871 ] 

Rishi Solanki commented on OFBIZ-8462:
--------------------------------------

[~devanshu.vyas]: Thanks for providing patch, looks good to me. Changed the ticket status to patch available. Thanks again.

> Improvements in ShipmentItemBilling entity definition and services
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-8462
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8462
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: datamodel
>    Affects Versions: Trunk
>            Reporter: Amit Gadaley
>            Priority: Minor
>         Attachments: OFBIZ-8462.patch
>
>
> Required improvements;
> - All is good with entity definition.
> - Add CRUD services using entity-auto.Make sure PK is not optional while create service as there is composite primary key.
> - Do related changes if any occurrence found for direct create/delete of this entity, and replace them with crud services implemented.
> - As no status/from date/thru date exists in entity, so nothing needs to be taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)