You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/19 03:33:14 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41228: [WIP] Upgrade maven plugins
panbingkun opened a new pull request, #41228:
URL: https://github.com/apache/spark/pull/41228
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #41228: [SPARK-43595][BUILD] Update some maven plugins to newest version
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41228:
URL: https://github.com/apache/spark/pull/41228#issuecomment-1555915926
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bjornjorgensen commented on pull request #41228: [SPARK-43595][BUILD] Update some maven plugins to newest version
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #41228:
URL: https://github.com/apache/spark/pull/41228#issuecomment-1557246884
@panbingkun dident you upgrade scala-maven-plugin from 4.8.0 to 4.8.1 in https://github.com/apache/spark/pull/40442
and @LuciferYang did have to revere it in https://github.com/apache/spark/commit/1530e8dc44d7d963791ede03d54b1c2ad5e91c99
CC @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bjornjorgensen commented on pull request #41228: [SPARK-43595][BUILD] Update some maven plugins to newest version
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #41228:
URL: https://github.com/apache/spark/pull/41228#issuecomment-1557130514
Using ./build/mvn I get this error with scala-maven-plugin.version 4.8.1
#14 238.4 [INFO] --- scala-maven-plugin:4.8.1:compile (scala-compile-first) @ spark-core_2.12 ---
#14 238.4 [INFO] Compiler bridge file: /root/.sbt/1.0/zinc/org.scala-sbt/org.scala-sbt-compiler-bridge_2.12-1.8.0-bin_2.12.17__61.0-1.8.0_20221110T195421.jar
#14 238.4 [INFO] compiler plugin: BasicArtifact(com.github.ghik,silencer-plugin_2.12.17,1.7.10,null)
#14 238.4 [INFO] compiling 602 Scala sources and 101 Java sources to /tmp/spark/core/target/scala-2.12/classes ...
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/serializer/SerializationDebugger.scala:71: not found: value sun
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/storage/StorageUtils.scala:26: not found: object sun
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/storage/StorageUtils.scala:27: not found: object sun
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/storage/StorageUtils.scala:206: not found: type DirectBuffer
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/storage/StorageUtils.scala:210: not found: type Unsafe
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/storage/StorageUtils.scala:212: not found: type Unsafe
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/storage/StorageUtils.scala:213: not found: type DirectBuffer
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/storage/StorageUtils.scala:216: not found: type DirectBuffer
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/storage/StorageUtils.scala:236: not found: type DirectBuffer
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala:452: not found: value sun
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/util/SignalUtils.scala:26: not found: object sun
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/util/SignalUtils.scala:99: not found: type SignalHandler
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/util/SignalUtils.scala:99: not found: type Signal
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/util/SignalUtils.scala:83: not found: type Signal
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/util/SignalUtils.scala:108: not found: type SignalHandler
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/util/SignalUtils.scala:108: not found: value Signal
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/util/SignalUtils.scala:114: not found: type Signal
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/util/SignalUtils.scala:116: not found: value Signal
Error: .4 [ERROR] [Error] /tmp/spark/core/src/main/scala/org/apache/spark/util/SignalUtils.scala:128: not found: value Signal
#14 238.4 [ERROR] 19 errors found
#14 238.4 [INFO] ------------------------------------------------------------------------
#14 238.4 [INFO] Reactor Summary for Spark Project Parent POM 3.5.0-SNAPSHOT:
#14 238.4 [INFO]
#14 238.4 [INFO] Spark Project Parent POM ........................... SUCCESS [ 34.963 s]
#14 238.4 [INFO] Spark Project Tags ................................. SUCCESS [ 23.148 s]
#14 238.4 [INFO] Spark Project Sketch ............................... SUCCESS [ 12.645 s]
#14 238.4 [INFO] Spark Project Local DB ............................. SUCCESS [ 17.202 s]
#14 238.4 [INFO] Spark Project Networking ........................... SUCCESS [ 20.815 s]
#14 238.4 [INFO] Spark Project Shuffle Streaming Service ............ SUCCESS [ 17.392 s]
#14 238.4 [INFO] Spark Project Unsafe ............................... SUCCESS [ 16.924 s]
#14 238.4 [INFO] Spark Project Common Utils ......................... SUCCESS [ 11.795 s]
#14 238.4 [INFO] Spark Project Launcher ............................. SUCCESS [ 13.309 s]
#14 238.4 [INFO] Spark Project Core ................................. FAILURE [ 40.546 s]
#14 238.4 [INFO] Spark Project ML Local Library ..................... SKIPPED
#14 238.4 [INFO] Spark Project GraphX ............................... SKIPPED
#14 238.4 [INFO] Spark Project Streaming ............................ SKIPPED
#14 238.4 [INFO] Spark Project Catalyst ............................. SKIPPED
#14 238.4 [INFO] Spark Project SQL .................................. SKIPPED
#14 238.4 [INFO] Spark Project ML Library ........................... SKIPPED
#14 238.4 [INFO] Spark Project Tools ................................ SKIPPED
#14 238.4 [INFO] Spark Project Hive ................................. SKIPPED
#14 238.4 [INFO] Spark Project REPL ................................. SKIPPED
#14 238.4 [INFO] Spark Project Assembly ............................. SKIPPED
#14 238.4 [INFO] Kafka 0.10+ Token Provider for Streaming ........... SKIPPED
#14 238.4 [INFO] Spark Integration for Kafka 0.10 ................... SKIPPED
#14 238.4 [INFO] Kafka 0.10+ Source for Structured Streaming ........ SKIPPED
#14 238.4 [INFO] Spark Project Examples ............................. SKIPPED
#14 238.4 [INFO] Spark Integration for Kafka 0.10 Assembly .......... SKIPPED
#14 238.4 [INFO] Spark Avro ......................................... SKIPPED
#14 238.4 [INFO] Spark Project Connect Common ....................... SKIPPED
#14 238.4 [INFO] Spark Protobuf ..................................... SKIPPED
#14 238.4 [INFO] Spark Project Connect Server ....................... SKIPPED
#14 238.4 [INFO] Spark Project Connect Client ....................... SKIPPED
#14 238.4 [INFO] ------------------------------------------------------------------------
#14 238.4 [INFO] BUILD FAILURE
#14 238.4 [INFO] ------------------------------------------------------------------------
#14 238.4 [INFO] Total time: 03:29 min
#14 238.4 [INFO] Finished at: 2023-05-22T10:27:14Z
#14 238.4 [INFO] ------------------------------------------------------------------------
#14 238.4 [ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:4.8.1:compile (scala-compile-first) on project spark-core_2.12: Execution scala-compile-first of goal net.alchim31.maven:scala-maven-plugin:4.8.1:compile failed: org.apache.commons.exec.ExecuteException: Process exited with an error: 255 (Exit value: 255) -> [Help 1]
#14 238.4 [ERROR]
#14 238.4 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
#14 238.4 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
#14 238.4 [ERROR]
#14 238.4 [ERROR] For more information about the errors and possible solutions, please read the following articles:
#14 238.4 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
When I change scala-maven-plugin.version to 4.8.0 it works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #41228: [SPARK-43595][BUILD] Update some maven plugins to newest version
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41228:
URL: https://github.com/apache/spark/pull/41228#issuecomment-1557264678
Let's revert that change and leave a note that this plugin cannot be updated further. It seems to be missing the JDK 'internal' classes, maybe for good reasons but I don't see why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #41228: [SPARK-43595][BUILD] Update some maven plugins to newest version
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #41228: [SPARK-43595][BUILD] Update some maven plugins to newest version
URL: https://github.com/apache/spark/pull/41228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org