You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/10 02:41:22 UTC

[GitHub] [spark] srowen commented on a change in pull request #26824: [SPARK-30197][PYSPARK] Add minimum `requirements.txt` file to `python` directory

srowen commented on a change in pull request #26824: [SPARK-30197][PYSPARK] Add minimum `requirements.txt` file to `python` directory
URL: https://github.com/apache/spark/pull/26824#discussion_r355819548
 
 

 ##########
 File path: python/requirements.txt
 ##########
 @@ -0,0 +1,4 @@
+numpy==1.16.4
+scipy==1.2.2
 
 Review comment:
   Heh, I didn't realize we directly use scipy. OK.
   
   Out of ignorance, what effect does this have on users of pyspark? like, without this, they are not guaranteed to have the right supporting dependencies right now?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org