You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/23 08:30:03 UTC
[GitHub] [kafka] hojongs opened a new pull request #11249: Fix wrong link to "Guarantees" part
hojongs opened a new pull request #11249:
URL: https://github.com/apache/kafka/pull/11249
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
From Kafka 2.5 release, the id of html tag `Guarantees` part has changed from `#intro_guarantees` to `#impl_guarantees`
But, the links in introduction.html file are still linking to the `#intro_guarantees`
So, the link is not working. (do nothing) -> Needed fix.
I fixed link, but previous versions of the documentation (~ 2.4 releases) are still not working.
To fix the links of documentations of prior releases, we can change back the id from `#impl_guarantees` to `#intro_guarantees`. (not fix links, but change the id of the html tag) But I'm not sure Which way is better. please comment :)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #11249: Fix wrong link to "Guarantees" part in introduction.html documentation
Posted by GitBox <gi...@apache.org>.
mimaison merged pull request #11249:
URL: https://github.com/apache/kafka/pull/11249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hojongs commented on a change in pull request #11249: Fix wrong link to "Guarantees" part in introduction.html documentation
Posted by GitBox <gi...@apache.org>.
hojongs commented on a change in pull request #11249:
URL: https://github.com/apache/kafka/pull/11249#discussion_r723837977
##########
File path: docs/introduction.html
##########
@@ -144,13 +144,13 @@ <h4 class="anchor-heading">
</li>
</ul>
<p>
- <strong>Producers</strong> are those client applications that publish (write) events to Kafka, and <strong>consumers</strong> are those that subscribe to (read and process) these events. In Kafka, producers and consumers are fully decoupled and agnostic of each other, which is a key design element to achieve the high scalability that Kafka is known for. For example, producers never need to wait for consumers. Kafka provides various <a href="/documentation/#intro_guarantees">guarantees</a> such as the ability to process events exactly-once.
+ <strong>Producers</strong> are those client applications that publish (write) events to Kafka, and <strong>consumers</strong> are those that subscribe to (read and process) these events. In Kafka, producers and consumers are fully decoupled and agnostic of each other, which is a key design element to achieve the high scalability that Kafka is known for. For example, producers never need to wait for consumers. Kafka provides various <a href="/documentation/#impl_guarantees">guarantees</a> such as the ability to process events exactly-once.
Review comment:
You're right. That's more make sense.
Applied at f017014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hojongs commented on a change in pull request #11249: Fix wrong link to "Guarantees" part in introduction.html documentation
Posted by GitBox <gi...@apache.org>.
hojongs commented on a change in pull request #11249:
URL: https://github.com/apache/kafka/pull/11249#discussion_r723837977
##########
File path: docs/introduction.html
##########
@@ -144,13 +144,13 @@ <h4 class="anchor-heading">
</li>
</ul>
<p>
- <strong>Producers</strong> are those client applications that publish (write) events to Kafka, and <strong>consumers</strong> are those that subscribe to (read and process) these events. In Kafka, producers and consumers are fully decoupled and agnostic of each other, which is a key design element to achieve the high scalability that Kafka is known for. For example, producers never need to wait for consumers. Kafka provides various <a href="/documentation/#intro_guarantees">guarantees</a> such as the ability to process events exactly-once.
+ <strong>Producers</strong> are those client applications that publish (write) events to Kafka, and <strong>consumers</strong> are those that subscribe to (read and process) these events. In Kafka, producers and consumers are fully decoupled and agnostic of each other, which is a key design element to achieve the high scalability that Kafka is known for. For example, producers never need to wait for consumers. Kafka provides various <a href="/documentation/#impl_guarantees">guarantees</a> such as the ability to process events exactly-once.
Review comment:
You're right. That's more make sense.
##########
File path: docs/introduction.html
##########
@@ -144,13 +144,13 @@ <h4 class="anchor-heading">
</li>
</ul>
<p>
- <strong>Producers</strong> are those client applications that publish (write) events to Kafka, and <strong>consumers</strong> are those that subscribe to (read and process) these events. In Kafka, producers and consumers are fully decoupled and agnostic of each other, which is a key design element to achieve the high scalability that Kafka is known for. For example, producers never need to wait for consumers. Kafka provides various <a href="/documentation/#intro_guarantees">guarantees</a> such as the ability to process events exactly-once.
+ <strong>Producers</strong> are those client applications that publish (write) events to Kafka, and <strong>consumers</strong> are those that subscribe to (read and process) these events. In Kafka, producers and consumers are fully decoupled and agnostic of each other, which is a key design element to achieve the high scalability that Kafka is known for. For example, producers never need to wait for consumers. Kafka provides various <a href="/documentation/#impl_guarantees">guarantees</a> such as the ability to process events exactly-once.
Review comment:
You're right. That's more make sense.
Applied at f017014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on a change in pull request #11249: Fix wrong link to "Guarantees" part in introduction.html documentation
Posted by GitBox <gi...@apache.org>.
mimaison commented on a change in pull request #11249:
URL: https://github.com/apache/kafka/pull/11249#discussion_r723050185
##########
File path: docs/introduction.html
##########
@@ -144,13 +144,13 @@ <h4 class="anchor-heading">
</li>
</ul>
<p>
- <strong>Producers</strong> are those client applications that publish (write) events to Kafka, and <strong>consumers</strong> are those that subscribe to (read and process) these events. In Kafka, producers and consumers are fully decoupled and agnostic of each other, which is a key design element to achieve the high scalability that Kafka is known for. For example, producers never need to wait for consumers. Kafka provides various <a href="/documentation/#intro_guarantees">guarantees</a> such as the ability to process events exactly-once.
+ <strong>Producers</strong> are those client applications that publish (write) events to Kafka, and <strong>consumers</strong> are those that subscribe to (read and process) these events. In Kafka, producers and consumers are fully decoupled and agnostic of each other, which is a key design element to achieve the high scalability that Kafka is known for. For example, producers never need to wait for consumers. Kafka provides various <a href="/documentation/#impl_guarantees">guarantees</a> such as the ability to process events exactly-once.
Review comment:
I wonder if pointing to https://kafka.apache.org/documentation/#semantics would actually make more sense. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hojongs commented on a change in pull request #11249: Fix wrong link to "Guarantees" part in introduction.html documentation
Posted by GitBox <gi...@apache.org>.
hojongs commented on a change in pull request #11249:
URL: https://github.com/apache/kafka/pull/11249#discussion_r723837977
##########
File path: docs/introduction.html
##########
@@ -144,13 +144,13 @@ <h4 class="anchor-heading">
</li>
</ul>
<p>
- <strong>Producers</strong> are those client applications that publish (write) events to Kafka, and <strong>consumers</strong> are those that subscribe to (read and process) these events. In Kafka, producers and consumers are fully decoupled and agnostic of each other, which is a key design element to achieve the high scalability that Kafka is known for. For example, producers never need to wait for consumers. Kafka provides various <a href="/documentation/#intro_guarantees">guarantees</a> such as the ability to process events exactly-once.
+ <strong>Producers</strong> are those client applications that publish (write) events to Kafka, and <strong>consumers</strong> are those that subscribe to (read and process) these events. In Kafka, producers and consumers are fully decoupled and agnostic of each other, which is a key design element to achieve the high scalability that Kafka is known for. For example, producers never need to wait for consumers. Kafka provides various <a href="/documentation/#impl_guarantees">guarantees</a> such as the ability to process events exactly-once.
Review comment:
You're right. That's more make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org