You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2016/07/13 06:56:13 UTC

[Issue 127040] New: Patch for arm 32

https://bz.apache.org/ooo/show_bug.cgi?id=127040

          Issue ID: 127040
        Issue Type: DEFECT
           Summary: Patch for arm 32
           Product: Build Tools
           Version: 4.2.0-dev
          Hardware: Other
                OS: Linux 32-bit
            Status: CONFIRMED
          Severity: Normal
          Priority: P5 (lowest)
         Component: configure
          Assignee: issues@openoffice.apache.org
          Reporter: eric.bachard@free.fr

It was not possible to build on Linux ARM (32 bits) with the trunk version of
Aoo, while it does perfectly build with OOo4Kids and OOoLight.

So, I propose a patch, using the same changes I did on ARM for OOo4Kids and
OOoLight a while ago, and perfectly building and working on recent armv7+
boards.

The attached patch, under Apache License, is a proposal (feel free to improve
it) to allow building AOo on :

- old fashion ARMV4T on old machines (was before the patch) ;
- softfp abi on ARMV6 ;
- hardfloat abi arm isa v7+ architectures.

IMPORTANT : after the patch being applied,and before configure, you MUST run
"autoconf" in the main directory, to apply and keep the proposed changes.

Modified files :

- solenv/inc/unxlngr.mk : added ARM_FLAVOUR, ARMV7 macros, improved ARM_TARGET
with better flags ;
- sal/osl/unx/intelck.c : added smp barriers (arm processors are multi-cores
since a while) ;
- configure_ac : added new cases, ARMV7 is now the default (doesn't make sense
to build OOo for previous architectures, but who knows ... ) ;
- set_soenv.in : added ARM_FLAVOUR macro ;
- modified EPM_FLAGS (needed when building the .debs) ;
- added OUTPATH : unxlngrh for hardfloat abi when available.

How to use it : 

at configure time, add :

--with-arm-target=7  (or 5, or 6 ... ) => will define ARMV7 macro
And in the case the libc is fpuv3 comptabile, the hardfloat abi will be used,
(else it will be the softfp).

Notes:
- this patch has just been partially tested with AOO build
- it has not been tested on armv8 (64 bits)
- default value is armv7+ isa ;
- the flags need to be checked after configure.

Tested on Raspberry Pi 3 rev. B

Regards,
Eric Bachard

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 127040] Patch for arm 32

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127040

eric.bachard@free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |new_implementation

--- Comment #1 from eric.bachard@free.fr ---
Setting some keywords.

Why does our public email appear in the issue ? 

This is open door to spam, and I'm not able to change that ?

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 127040] Patch for arm 32

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127040

--- Comment #5 from Matthias Seidel <ms...@apache.org> ---
Has this patch ever been applied?

It would be great to have AOO on a Raspberry Pi.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 127040] Patch for arm 32

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127040

Andrea Pescetti <pe...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pescetti@apache.org

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 127040] Patch for arm 32

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127040

--- Comment #3 from eric.bachard@free.fr ---
Created attachment 85606
  --> https://bz.apache.org/ooo/attachment.cgi?id=85606&action=edit
Patch to allow building on arm 32 bits

Sorry, I believed it was attached.

Apologies :-/

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 127040] Patch for arm 32

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127040

damjan@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |damjan@apache.org

--- Comment #2 from damjan@apache.org ---
(In reply to eric.bachard from comment #1)
> Setting some keywords.
> 
> Why does our public email appear in the issue ? 
> 
> This is open door to spam, and I'm not able to change that ?

It only appears to logged in users.

Where is your patch?

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 127040] Patch for arm 32

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127040

Matthias Seidel <ms...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mseidel@apache.org

-- 
You are receiving this mail because:
You are the assignee for the issue.

Is this arm patch still usable?

Posted by Peter Kovacs <pe...@apache.org>.
Hello marcia,

Hello Don,


If you got some time can you check the patch from below if it is still 
needed?

It differs quite a lot from the existing config. (see bellow)

maybe it gives also some pointers to make the build work. Would be nice 
if you could help here out.


Thanks.

All the best

Peter



-------- Forwarded Message --------
Subject: 	[Issue 127040] Patch for arm 32
Date: 	Sun, 30 May 2021 08:44:55 +0000
From: 	bugzilla@apache.org
Reply-To: 	issues@openoffice.apache.org
To: 	issues@openoffice.apache.org



https://bz.apache.org/ooo/show_bug.cgi?id=127040

Peter <pe...@apache.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |petko@apache.org

--- Comment #6 from Peter <pe...@apache.org> ---
Okay, the patch has not been applied.
But it is seems outdated, too. Maybe we should ask for some guidance.
The patch sets some variables different then our current ARM config.
Depending on platform it sets:
$EPM_FLAGS = "-a armhf";
or
$EPM_FLAGS = "-a armel";

However our ARM config sets
$EPM_FLAGS = "-a arm";

Someone needs to check this what is still needed and what is out dated 
from ARM
perspective.

-- 
You are receiving this mail because:
You are the assignee for the issue.


[Issue 127040] Patch for arm 32

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127040

Peter <pe...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |petko@apache.org

--- Comment #6 from Peter <pe...@apache.org> ---
Okay, the patch has not been applied.
But it is seems outdated, too. Maybe we should ask for some guidance.
The patch sets some variables different then our current ARM config.
Depending on platform it sets:
$EPM_FLAGS    = "-a armhf";
or
$EPM_FLAGS    = "-a armel";

However our ARM config sets
$EPM_FLAGS      = "-a arm";

Someone needs to check this what is still needed and what is out dated from ARM
perspective.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 127040] Patch for arm 32

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127040

oooforum (fr) <oo...@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Issue Type|DEFECT                      |PATCH
                 CC|                            |oooforum@free.fr

--- Comment #4 from oooforum (fr) <oo...@free.fr> ---
Good to see come back ;-)
Set status as PATCH

-- 
You are receiving this mail because:
You are the assignee for the issue.