You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/21 21:16:17 UTC

[GitHub] [arrow] davidanthoff commented on a change in pull request #7001: Use lowercase ws2_32 everywhere

davidanthoff commented on a change in pull request #7001:
URL: https://github.com/apache/arrow/pull/7001#discussion_r412497174



##########
File path: cpp/cmake_modules/FindThrift.cmake
##########
@@ -100,7 +100,7 @@ if(Thrift_FOUND OR THRIFT_FOUND)
                                    INTERFACE_INCLUDE_DIRECTORIES "${THRIFT_INCLUDE_DIR}")
   if(WIN32 AND NOT MSVC)
     # We don't need this for Visual C++ because Thrift uses
-    # "#pragma comment(lib, "Ws2_32.lib")" in
+    # "#pragma comment(lib, "ws2_32.lib")" in

Review comment:
       That makes sense, I adjusted this.
   
   I should probably double check that the cross compile still works without this, though. Will report once I have tried that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org