You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2015/09/01 19:43:18 UTC
[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/711
STORM-996: netty-unit-tests/test-batch demonstrates out-of-order delivery
Netty calls notifyInterestChanged which causes a race condition in flushMessages.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-996
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/711.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #711
----
commit 11886c0c4c3aa2547b1ef571712bed83229dc4e4
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-09-01T17:13:05Z
Netty Fix.
commit 3783f4e6669d185d5a0fd42468347238350c2774
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2015-09-01T17:37:01Z
Whitespace
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/711#issuecomment-136859814
+1
Great! Missed StormClientHandler so there's only one thread which accesses to Client at any time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/711#issuecomment-136813085
+1 This seems to fix the issue. I ran test-batch ~50 times without a failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/711#issuecomment-136884363
+1 Nice work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/711#issuecomment-136840377
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-996: netty-unit-tests/test-batch demonst...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/711
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---