You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/22 08:24:43 UTC

[GitHub] [pulsar] nodece opened a new pull request, #16735: [fix][flaky-test] Fix BacklogQuotaManagerTest.testConsumerBacklogEvictionTimeQuotaWithEmptyLedge

nodece opened a new pull request, #16735:
URL: https://github.com/apache/pulsar/pull/16735

   Fixes #16733 
   
   ### Motivation
   
   This is a flaky test, which looks have the incorrect condition.
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #16735: [fix][flaky-test] Fix BacklogQuotaManagerTest.testConsumerBacklogEvictionTimeQuotaWithEmptyLedge

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #16735:
URL: https://github.com/apache/pulsar/pull/16735#issuecomment-1193503702

   This flaky-test should be fixed.
   
   A new flaky-test in `Pulsar CI / CI - Unit - Brokers - Broker Group 2 (pull_request)`:
   ```
     Error:  Tests run: 15, Failures: 7, Errors: 0, Skipped: 8, Time elapsed: 67.378 s <<< FAILURE! - in org.apache.pulsar.io.PulsarSinkE2ETest
     Error:  testPulsarSinkDLQ(org.apache.pulsar.io.PulsarSinkE2ETest)  Time elapsed: 17.67 s  <<< FAILURE!
     java.lang.AssertionError: expected object to not be null
     	at org.testng.Assert.fail(Assert.java:99)
     	at org.testng.Assert.assertNotNull(Assert.java:942)
     	at org.testng.Assert.assertNotNull(Assert.java:926)
     	at org.apache.pulsar.io.PulsarSinkE2ETest.testPulsarSinkDLQ(PulsarSinkE2ETest.java:195)
     	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
     	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
     	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
     	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
     	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
     	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
     	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
     	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
     	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
     	at java.base/java.lang.Thread.run(Thread.java:833)
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codelipenghui commented on pull request #16735: [fix][flaky-test] Fix BacklogQuotaManagerTest.testConsumerBacklogEvictionTimeQuotaWithEmptyLedge

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #16735:
URL: https://github.com/apache/pulsar/pull/16735#issuecomment-1193040730

   @nodece The test still failed with this change https://github.com/apache/pulsar/runs/7466520244?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codelipenghui merged pull request #16735: [fix][flaky-test] Fix BacklogQuotaManagerTest.testConsumerBacklogEvictionTimeQuotaWithEmptyLedge

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16735:
URL: https://github.com/apache/pulsar/pull/16735


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #16735: [fix][flaky-test] Fix BacklogQuotaManagerTest.testConsumerBacklogEvictionTimeQuotaWithEmptyLedge

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #16735:
URL: https://github.com/apache/pulsar/pull/16735#issuecomment-1193503820

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org