You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kaya-abdullah (via GitHub)" <gi...@apache.org> on 2026/10/15 13:23:17 UTC

[PR] fix(sql): bump sqlglot to 30.23.0 [superset]

kaya-abdullah opened a new pull request, #45343:
URL: https://github.com/apache/superset/pull/45343

   ### SUMMARY
   
   Raises the sqlglot floor and pins to 30.23.0, which parses two things SQL Lab rejects today:
   
   - Postgres `JSON_VALUE(... RETURNING <type>)`, the Postgres half of #36954 (tobymao/sqlglot#8579). The regression test for it was suggested in that issue once the sqlglot release was out.
   - Doris full-text search operators (`MATCH_ANY`, `MATCH_ALL`, `MATCH_PHRASE`, ...), #36770 (tobymao/sqlglot#8585).
   
   It adds a regression test for each, next to the Druid one from #45131.
   
   The bump needs two changes in the StarRocks dialect, because 30.22.0 and 30.23.0 moved things our overrides were covering into sqlglot itself:
   
   - 30.22.0 added a `kind` argument to `Parser._parse_drop`. Our `_parse_drop` override doesn't take it, so `ALTER TABLE ... DROP ROLLUP` and `DROP TEMPORARY PARTITION` fail with `TypeError: StarRocksParser._parse_drop() got an unexpected keyword argument 'kind'`. The override only existed to parse the dotted table in `DROP INDEX idx ON db.table`, which sqlglot's own `_parse_drop` now handles, so I removed it.
   - 30.23.0 added `PARTITION START/END`, `FORCE` and `WITH {SYNC|ASYNC} MODE` to `exp.Refresh` and renders them in the StarRocks generator. Our `refresh_sql` appended the same clauses again, so `REFRESH MATERIALIZED VIEW mv WITH SYNC MODE` came out as `... WITH SYNC MODE WITH SYNC MODE`. I removed the appending code and the `StarRocksMaterializedViewRefresh` subclass, which `exp.Refresh` now covers. Our `_parse_refresh` stays, since it also handles `DICTIONARY` and `CONNECTIONS`, and builds a plain `exp.Refresh` now.
   
   The existing StarRocks tests cover what the removed code did (`DROP INDEX index_name ON db.table1`, `DROP ROLLUP`, `DROP TEMPORARY PARTITION` and every `REFRESH MATERIALIZED VIEW` form), and they pass unchanged; no test was removed or edited. sqlglot also pins the same behaviour in its own tests: `DROP INDEX i ON db.t` in the MySQL tests, which the StarRocks parser inherits, and `REFRESH MATERIALIZED VIEW db.lo_mv1 PARTITION START ('2020-02-01') END ('2020-03-01') FORCE WITH SYNC MODE` in the StarRocks tests (tobymao/sqlglot#8613).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A, no UI change. Results from SQL Lab against real databases, before (master), with only the version bump, and with this PR:
   
   | Query | master (30.21.0) | bump only (30.23.0) | this PR |
   |---|---|---|---|
   | Postgres 17: `SELECT JSON_VALUE(h, '$.a' RETURNING BIGINT) AS x FROM t` | Error parsing near 'RETURNING' | | works |
   | Postgres 17: `... JSON_VALUE(h, CONCAT('$.', d) RETURNING BIGINT) ...` | Error parsing near 'RETURNING' | | works |
   | Doris 4.1.3: `SELECT id FROM t WHERE c MATCH_ANY 'word1 word2'` | Error parsing near 'MATCH_ANY' | | works |
   | Doris 4.1.3: `... WHERE c MATCH_PHRASE 'word1 word2'` | Error parsing near 'MATCH_PHRASE' | | works |
   | StarRocks 3.5.5: `REFRESH MATERIALIZED VIEW mv WITH SYNC MODE` | works | Error parsing near 'WITH' | works |
   | StarRocks 3.5.5: `REFRESH MATERIALIZED VIEW mv PARTITION START ('2020-02-01') END ('2020-03-01') FORCE WITH SYNC MODE` | works | Error parsing near 'PARTITION' | works |
   | StarRocks 3.5.5: `ALTER TABLE db.t DROP ROLLUP r1` | works | TypeError (`kind`) | works |
   | StarRocks 3.5.5: `DROP INDEX idx ON db.t` | works | works | works |
   
   ### TESTING INSTRUCTIONS
   
       pytest tests/unit_tests/sql/
   
   All 2316 tests in `tests/unit_tests/sql/` pass with this PR. The StarRocks changes are needed for the bump: without them, sqlglot 30.23.0 breaks seven StarRocks tests. The new Postgres and Doris tests fail on sqlglot 30.22.0, so they catch the bugs from the issues.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: Fixes #36770, refs #36954
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(sql): bump sqlglot to 30.23.0 [superset]

Posted by "kaya-abdullah (via GitHub)" <gi...@apache.org>.
kaya-abdullah commented on code in PR #45343:
URL: https://github.com/apache/superset/pull/45343#discussion_r4288943748


##########
tests/unit_tests/sql/parse_tests.py:
##########
@@ -1846,6 +1846,57 @@ def test_druid_parses_json_value_returning(sql: str) -> None:
     assert "RETURNING BIGINT" in SQLScript(sql, "druid").format()
 
 
+@pytest.mark.parametrize(
+    "sql",
+    [
+        "SELECT JSON_VALUE(h, '$.a' RETURNING BIGINT) AS x FROM t",
+        "SELECT JSON_VALUE(h, CONCAT('$.', d) RETURNING BIGINT) AS x FROM t",
+    ],
+)
+def test_postgres_parses_json_value_returning(sql: str) -> None:
+    """
+    Regression for #36954: the same ``JSON_VALUE ... RETURNING <type>`` clause
+    failed for Postgres with "Error parsing near 'returning'". sqlglot parses it
+    for the Postgres dialect since 30.23.0 and keeps the JSON path as written, so
+    this pins both against a future upgrade.
+    """
+    formatted = SQLScript(sql, "postgresql").format()
+    assert "RETURNING BIGINT" in formatted
+    assert "$." in formatted

Review Comment:
   Done in eafd95f: the test now asserts the whole `JSON_VALUE(h, <path> RETURNING BIGINT)` call for each case, so a rewritten path fails it.



##########
tests/unit_tests/sql/parse_tests.py:
##########
@@ -1846,6 +1846,57 @@ def test_druid_parses_json_value_returning(sql: str) -> None:
     assert "RETURNING BIGINT" in SQLScript(sql, "druid").format()
 
 
+@pytest.mark.parametrize(
+    "sql",
+    [
+        "SELECT JSON_VALUE(h, '$.a' RETURNING BIGINT) AS x FROM t",
+        "SELECT JSON_VALUE(h, CONCAT('$.', d) RETURNING BIGINT) AS x FROM t",
+    ],
+)
+def test_postgres_parses_json_value_returning(sql: str) -> None:
+    """
+    Regression for #36954: the same ``JSON_VALUE ... RETURNING <type>`` clause
+    failed for Postgres with "Error parsing near 'returning'". sqlglot parses it
+    for the Postgres dialect since 30.23.0 and keeps the JSON path as written, so
+    this pins both against a future upgrade.
+    """
+    formatted = SQLScript(sql, "postgresql").format()
+    assert "RETURNING BIGINT" in formatted
+    assert "$." in formatted
+
+
+@pytest.mark.parametrize(
+    "operator",
+    [
+        "MATCH",
+        "MATCH_ANY",
+        "MATCH_ALL",
+        "MATCH_PHRASE",
+        "MATCH_PHRASE_PREFIX",
+        "MATCH_PHRASE_EDGE",
+        "MATCH_REGEXP",
+    ],
+)
+def test_doris_parses_full_text_search_operators(operator: str) -> None:
+    """
+    Regression for #36770: Doris full-text search operators failed in SQL Lab
+    with "Invalid expression / Unexpected token". sqlglot parses them for the
+    Doris dialect since 30.23.0, so this pins them against a future upgrade.
+    """
+    sql = f"SELECT * FROM t WHERE c {operator} 'word1 word2'"  # noqa: S608
+    assert f"c {operator} 'word1 word2'" in SQLScript(sql, "pydoris").format()
+
+
+def test_doris_parses_match_with_analyzer() -> None:
+    """
+    Doris also takes a parenthesized operand and ``USING ANALYZER`` after it.
+    """
+    sql = "SELECT * FROM t WHERE c NOT MATCH_ANY ('x') USING ANALYZER 'standard'"
+    formatted = SQLScript(sql, "pydoris").format()
+    assert "MATCH_ANY (" in formatted
+    assert "USING ANALYZER 'standard'" in formatted

Review Comment:
   Done in eafd95f: it now matches `NOT c MATCH_ANY ('x') USING ANALYZER 'standard'` with a regex that allows any whitespace, which also checks the NOT.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(sql): bump sqlglot to 30.23.0 [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45343:
URL: https://github.com/apache/superset/pull/45343#issuecomment-6193897736

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45343?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `33.33333%` with `2 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 64.92%. Comparing base ([`f808b98`](https://app.codecov.io/gh/apache/superset/commit/f808b982a59b591359e5fd05bfccfc428bc355b3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c566876`](https://app.codecov.io/gh/apache/superset/commit/c566876f50a419a8b05fb03a99c58341fb2af2d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/45343?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/sql/dialects/starrocks.py](https://app.codecov.io/gh/apache/superset/pull/45343?src=pr&el=tree&filepath=superset%2Fsql%2Fdialects%2Fstarrocks.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc3FsL2RpYWxlY3RzL3N0YXJyb2Nrcy5weQ==) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/45343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (f808b98) and HEAD (c566876). Click for more details.
   > 
   > <details><summary>HEAD has 2 uploads less than BASE</summary>
   >
   >| Flag | BASE (f808b98) | HEAD (c566876) |
   >|------|------|------|
   >|python|5|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #45343       +/-   ##
   ===========================================
   - Coverage   83.45%   64.92%   -18.54%     
   ===========================================
     Files        3045     3045               
     Lines      199180   199147       -33     
     Branches    46445    46438        -7     
   ===========================================
   - Hits       166230   129300    -36930     
   - Misses      29722    66933    +37211     
   + Partials     3228     2914      -314     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/45343/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/45343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.01% <33.33%> (+<0.01%)` | :arrow_up: |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/45343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/45343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.76% <33.33%> (+<0.01%)` | :arrow_up: |
   | [python](https://app.codecov.io/gh/apache/superset/pull/45343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.85% <33.33%> (-34.12%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/45343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.74% <33.33%> (+0.01%)` | :arrow_up: |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/45343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45343?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(sql): bump sqlglot to 30.23.0 [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #45343:
URL: https://github.com/apache/superset/pull/45343#discussion_r4286215912


##########
tests/unit_tests/sql/parse_tests.py:
##########
@@ -1846,6 +1846,57 @@ def test_druid_parses_json_value_returning(sql: str) -> None:
     assert "RETURNING BIGINT" in SQLScript(sql, "druid").format()
 
 
+@pytest.mark.parametrize(
+    "sql",
+    [
+        "SELECT JSON_VALUE(h, '$.a' RETURNING BIGINT) AS x FROM t",
+        "SELECT JSON_VALUE(h, CONCAT('$.', d) RETURNING BIGINT) AS x FROM t",
+    ],
+)
+def test_postgres_parses_json_value_returning(sql: str) -> None:
+    """
+    Regression for #36954: the same ``JSON_VALUE ... RETURNING <type>`` clause
+    failed for Postgres with "Error parsing near 'returning'". sqlglot parses it
+    for the Postgres dialect since 30.23.0 and keeps the JSON path as written, so
+    this pins both against a future upgrade.
+    """
+    formatted = SQLScript(sql, "postgresql").format()
+    assert "RETURNING BIGINT" in formatted
+    assert "$." in formatted
+
+
+@pytest.mark.parametrize(
+    "operator",
+    [
+        "MATCH",
+        "MATCH_ANY",
+        "MATCH_ALL",
+        "MATCH_PHRASE",
+        "MATCH_PHRASE_PREFIX",
+        "MATCH_PHRASE_EDGE",
+        "MATCH_REGEXP",
+    ],
+)
+def test_doris_parses_full_text_search_operators(operator: str) -> None:
+    """
+    Regression for #36770: Doris full-text search operators failed in SQL Lab
+    with "Invalid expression / Unexpected token". sqlglot parses them for the
+    Doris dialect since 30.23.0, so this pins them against a future upgrade.
+    """
+    sql = f"SELECT * FROM t WHERE c {operator} 'word1 word2'"  # noqa: S608
+    assert f"c {operator} 'word1 word2'" in SQLScript(sql, "pydoris").format()
+
+
+def test_doris_parses_match_with_analyzer() -> None:
+    """
+    Doris also takes a parenthesized operand and ``USING ANALYZER`` after it.
+    """
+    sql = "SELECT * FROM t WHERE c NOT MATCH_ANY ('x') USING ANALYZER 'standard'"
+    formatted = SQLScript(sql, "pydoris").format()
+    assert "MATCH_ANY (" in formatted
+    assert "USING ANALYZER 'standard'" in formatted

Review Comment:
   The assertion `assert "MATCH_ANY (" in formatted` is brittle because it depends on a specific whitespace rendering (`"MATCH_ANY ("` vs `"MATCH_ANY("`) that could change across `sqlglot` versions without altering correctness. Consider using a whitespace-tolerant check (e.g., regex with `\s*`), normalizing whitespace before asserting, or asserting on the parsed AST shape instead of string formatting.



##########
tests/unit_tests/sql/parse_tests.py:
##########
@@ -1846,6 +1846,57 @@ def test_druid_parses_json_value_returning(sql: str) -> None:
     assert "RETURNING BIGINT" in SQLScript(sql, "druid").format()
 
 
+@pytest.mark.parametrize(
+    "sql",
+    [
+        "SELECT JSON_VALUE(h, '$.a' RETURNING BIGINT) AS x FROM t",
+        "SELECT JSON_VALUE(h, CONCAT('$.', d) RETURNING BIGINT) AS x FROM t",
+    ],
+)
+def test_postgres_parses_json_value_returning(sql: str) -> None:
+    """
+    Regression for #36954: the same ``JSON_VALUE ... RETURNING <type>`` clause
+    failed for Postgres with "Error parsing near 'returning'". sqlglot parses it
+    for the Postgres dialect since 30.23.0 and keeps the JSON path as written, so
+    this pins both against a future upgrade.
+    """
+    formatted = SQLScript(sql, "postgresql").format()
+    assert "RETURNING BIGINT" in formatted
+    assert "$." in formatted

Review Comment:
   `assert "$." in formatted` is a fairly weak signal for “JSON path preserved as written” and can pass even if the original path was transformed (or if `$.` appears elsewhere in the formatted SQL). To better “pin” the regression against future `sqlglot` upgrades, consider asserting the presence of the specific path literal(s) used by each parametrized input (e.g., `'$.a'` in the first case and `"CONCAT('$.', d)"` in the second), or asserting against the parsed AST’s JSON path argument rather than a broad substring.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(sql): pin Postgres JSON_VALUE RETURNING and Doris full-text search parsing [superset]

Posted by "kaya-abdullah (via GitHub)" <gi...@apache.org>.
kaya-abdullah commented on PR #45343:
URL: https://github.com/apache/superset/pull/45343#issuecomment-6483100503

   #45704 took the sqlglot bump and the StarRocks fixes, so I reduced this PR to the Postgres and Doris regression tests on top of current master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(sql): bump sqlglot to 30.23.0 [superset]

Posted by "kaya-abdullah (via GitHub)" <gi...@apache.org>.
kaya-abdullah commented on PR #45343:
URL: https://github.com/apache/superset/pull/45343#issuecomment-6300712343

   Thanks for the review. Rebased onto current master and the fresh CI run is green, including unit-tests (current) and the testcontainers matrix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(sql): bump sqlglot to 30.23.0 [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45343:
URL: https://github.com/apache/superset/pull/45343#issuecomment-6193267495

   ## CodeAnt PR Risk: Low Risk
   
   - The PR appears safe to merge: the sqlglot update is narrow and includes regression tests for the reported PostgreSQL and Doris parsing cases.
   - The StarRocks parser and generator now rely on sqlglot's built-in handling for refresh clauses; no concrete regression is evident in the supplied changes.
   
   **Assessed commit:** `c566876f50a4`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(sql): bump sqlglot to 30.23.0 [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45343:
URL: https://github.com/apache/superset/pull/45343#issuecomment-6203706673

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | eafd95f90a9aa7560ec9a1244543cae5cdf99331 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ad1547ff61b241c31bd2063 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45343--superset-docs-preview.netlify.app](https://deploy-preview-45343--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ1MzQzLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.YQFO13jE8wD01nJeP82nDiY8acvSuSh2P6JLsZ9ajUw)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#q1YqKMrPLShRslJS0lFKKkrMS84AspMz8otS9YsLc9Jz8kt0jQ10jYyB0impBTn5lZ4pQAVmiSmGpibmaWlmhklGJobJxoZJKUYGZsZKtQA) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-45343--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org