You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tushushu (via GitHub)" <gi...@apache.org> on 2024/01/08 11:34:25 UTC
[PR] Standardize compression encoding in protobuf [arrow-datafusion]
tushushu opened a new pull request, #8785:
URL: https://github.com/apache/arrow-datafusion/pull/8785
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #8680.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Standardize `CompressionTypeVariant` encoding in protobuf [arrow-datafusion]
Posted by "tushushu (via GitHub)" <gi...@apache.org>.
tushushu commented on PR #8785:
URL: https://github.com/apache/arrow-datafusion/pull/8785#issuecomment-1884210695
> I took the liberty if making @jonahgao 's suggestion to use `reserved` as well as resolving the clippy error to get this PR's CI checks green
Thanks so much Andrew for the commits, I was supposed to submit the code yesterday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Standardize `CompressionTypeVariant` encoding in protobuf [arrow-datafusion]
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada merged PR #8785:
URL: https://github.com/apache/arrow-datafusion/pull/8785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Standardize compression encoding in protobuf [arrow-datafusion]
Posted by "tushushu (via GitHub)" <gi...@apache.org>.
tushushu commented on PR #8785:
URL: https://github.com/apache/arrow-datafusion/pull/8785#issuecomment-1880833453
This PR is not ready for a review yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Standardize `CompressionTypeVariant` encoding in protobuf [arrow-datafusion]
Posted by "tushushu (via GitHub)" <gi...@apache.org>.
tushushu commented on code in PR #8785:
URL: https://github.com/apache/arrow-datafusion/pull/8785#discussion_r1446893788
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -212,7 +212,7 @@ message CreateExternalTableNode {
bool if_not_exists = 7;
string delimiter = 8;
string definition = 9;
- string file_compression_type = 10;
+ CompressionTypeVariant file_compression_type = 10;
Review Comment:
I was not aware of this, thanks @jonahgao for the advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Standardize compression encoding in protobuf [arrow-datafusion]
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao commented on code in PR #8785:
URL: https://github.com/apache/arrow-datafusion/pull/8785#discussion_r1444651501
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -212,7 +212,7 @@ message CreateExternalTableNode {
bool if_not_exists = 7;
string delimiter = 8;
string definition = 9;
- string file_compression_type = 10;
+ CompressionTypeVariant file_compression_type = 10;
Review Comment:
I think we should avoid reusing tag numbers.
The reasons can be referenced here.
- [Don’t Re-use a Tag Number
](https://protobuf.dev/programming-guides/dos-donts/#reuse-number)
- [Don’t Change the Type of a Field](https://protobuf.dev/programming-guides/dos-donts/#change-type)
I prefer to make changes like the following.
```proto
reserved 10; // was string file_compression_type
CompressionTypeVariant file_compression_type = 17;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org