You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by Cédric Champeau <ce...@gmail.com> on 2017/04/01 17:00:04 UTC
Re: groovy git commit: Replace the local dependency jar with the one
on jitpack repository
I think we should avoid using Jitpack. It leads to non-reproducible builds,
because it builds dependencies from sources. We should also avoid
dependencies onto snapshots. At least, for releases.
2017-04-01 14:26 GMT+02:00 <su...@apache.org>:
> Repository: groovy
> Updated Branches:
> refs/heads/parrot 4fb80a1ce -> 9a0aa6095
>
>
> Replace the local dependency jar with the one on jitpack repository
>
>
> Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
> Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/9a0aa609
> Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/9a0aa609
> Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/9a0aa609
>
> Branch: refs/heads/parrot
> Commit: 9a0aa6095feee4a22658b3479802a28eb56c7ca2
> Parents: 4fb80a1
> Author: sunlan <su...@apache.org>
> Authored: Sat Apr 1 20:26:38 2017 +0800
> Committer: sunlan <su...@apache.org>
> Committed: Sat Apr 1 20:26:38 2017 +0800
>
> ----------------------------------------------------------------------
> build.gradle | 5 ++++-
> lib/antlr4-gradle-plugin-0.1.2-SNAPSHOT.jar | Bin 16443 -> 0 bytes
> 2 files changed, 4 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/groovy/blob/9a0aa609/build.gradle
> ----------------------------------------------------------------------
> diff --git a/build.gradle b/build.gradle
> index 33452df..2dee7bc 100644
> --- a/build.gradle
> +++ b/build.gradle
> @@ -31,6 +31,9 @@ buildscript {
> maven {
> url "https://plugins.gradle.org/m2/"
> }
> + maven {
> + url 'https://jitpack.io'
> + }
> }
>
> dependencies {
> @@ -43,7 +46,7 @@ buildscript {
> classpath "gradle.plugin.org.nosphere.
> apache:creadur-rat-gradle:0.1.3"
> classpath "gradle.plugin.com.github.jk1:
> gradle-license-report:0.3.2"
>
> - classpath files("lib/antlr4-gradle-plugin-0.1.2-SNAPSHOT.jar");
> + classpath "com.github.danielsun1106:antlr4-gradle-plugin:v0.1.2"
> }
> }
>
>
> http://git-wip-us.apache.org/repos/asf/groovy/blob/
> 9a0aa609/lib/antlr4-gradle-plugin-0.1.2-SNAPSHOT.jar
> ----------------------------------------------------------------------
> diff --git a/lib/antlr4-gradle-plugin-0.1.2-SNAPSHOT.jar
> b/lib/antlr4-gradle-plugin-0.1.2-SNAPSHOT.jar
> deleted file mode 100644
> index 638ed51..0000000
> Binary files a/lib/antlr4-gradle-plugin-0.1.2-SNAPSHOT.jar and /dev/null
> differ
>
>