You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/07 18:57:48 UTC

[GitHub] [kafka] mumrah opened a new pull request #10992: MINOR: Remove nullable from addingReplicas and removingReplicas

mumrah opened a new pull request #10992:
URL: https://github.com/apache/kafka/pull/10992


   This change was discussed in KIP-746 and are actually included in #10753. I'm pulling them out here since there are NPEs on trunk as a result of the nullable fields in the PartitionRecord. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe edited a comment on pull request #10992: MINOR: Remove nullable from addingReplicas and removingReplicas

Posted by GitBox <gi...@apache.org>.
cmccabe edited a comment on pull request #10992:
URL: https://github.com/apache/kafka/pull/10992#issuecomment-875898150


   Thanks, @mumrah !
   
   Can you use `Replicas.NONE` instead of `new int[0]`? It saves an allocation.
   
   LGTM after that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe merged pull request #10992: MINOR: Remove nullable from addingReplicas and removingReplicas

Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #10992:
URL: https://github.com/apache/kafka/pull/10992


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe commented on pull request #10992: MINOR: Remove nullable from addingReplicas and removingReplicas

Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #10992:
URL: https://github.com/apache/kafka/pull/10992#issuecomment-875898150


   Thanks, @mumrah !
   
   Can you use `Replicas.EMPTY` instead of `new int[0]`? It saves an allocation.
   
   LGTM after that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org