You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by qh...@apache.org on 2015/10/29 10:25:47 UTC
incubator-kylin git commit: fix CI,
ignore check for dictionary on TopN measure when building empty
segment
Repository: incubator-kylin
Updated Branches:
refs/heads/2.x-staging 0287e0cd7 -> 596304b0d
fix CI, ignore check for dictionary on TopN measure when building empty segment
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/596304b0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/596304b0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/596304b0
Branch: refs/heads/2.x-staging
Commit: 596304b0d1a0d9a52bbef33edc9c68677aa7a657
Parents: 0287e0c
Author: qianhao.zhou <qi...@ebay.com>
Authored: Thu Oct 29 17:24:45 2015 +0800
Committer: qianhao.zhou <qi...@ebay.com>
Committed: Thu Oct 29 17:25:26 2015 +0800
----------------------------------------------------------------------
.../org/apache/kylin/cube/inmemcubing/InMemCubeBuilderUtils.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/596304b0/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilderUtils.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilderUtils.java b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilderUtils.java
index 3b68d47..f0ee372 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilderUtils.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilderUtils.java
@@ -17,7 +17,6 @@
*/
package org.apache.kylin.cube.inmemcubing;
-import com.google.common.base.Preconditions;
import com.google.common.collect.Maps;
import org.apache.kylin.common.util.ImmutableBitSet;
import org.apache.kylin.common.util.Pair;
@@ -47,7 +46,8 @@ public final class InMemCubeBuilderUtils {
TblColRef displayCol = func.getParameter().getColRefs().get(flatTableIdx.length - 1);
@SuppressWarnings("unchecked")
Dictionary<String> dictionary = (Dictionary<String>) dictionaryMap.get(displayCol);
- result.put(displayColIdx, Preconditions.checkNotNull(dictionary));
+ //Preconditions.checkNotNull(dictionary);//FIXME disable check since dictionary is null when building empty segment
+ result.put(displayColIdx, dictionary);
}
}
return result;