You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/01/15 23:07:55 UTC

[GitHub] [cassandra] dcapwell commented on a change in pull request #424: CASSANDRA-15507 failingReadRepairTest was not triggering a repair on the third node as expected, so fixed the test to make the expected semantics

dcapwell commented on a change in pull request #424: CASSANDRA-15507 failingReadRepairTest was not triggering a repair on the third node as expected, so fixed the test to make the expected semantics
URL: https://github.com/apache/cassandra/pull/424#discussion_r367155016
 
 

 ##########
 File path: test/distributed/org/apache/cassandra/distributed/test/DistributedTestBase.java
 ##########
 @@ -94,7 +94,7 @@ public static void assertRows(Object[][] actual, Object[]... expected)
         {
             Object[] expectedRow = expected[i];
             Object[] actualRow = actual[i];
-            Assert.assertTrue(rowsNotEqualErrorMessage(expected, actual),
+            Assert.assertTrue(rowsNotEqualErrorMessage(actual, expected),
 
 Review comment:
   this was flipped so caused confusing error messages.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org