You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by do...@apache.org on 2009/04/30 03:59:21 UTC
svn commit: r770034 - in
/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition:
EntityComparisonOperator.java EntityOperator.java
Author: doogie
Date: Thu Apr 30 01:59:21 2009
New Revision: 770034
URL: http://svn.apache.org/viewvc?rev=770034&view=rev
Log:
Some tightening of generics.
Modified:
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityComparisonOperator.java
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityOperator.java
Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityComparisonOperator.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityComparisonOperator.java?rev=770034&r1=770033&r2=770034&view=diff
==============================================================================
--- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityComparisonOperator.java (original)
+++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityComparisonOperator.java Thu Apr 30 01:59:21 2009
@@ -127,7 +127,7 @@
}
}
- public boolean compare(Comparable lhs, Object rhs) {
+ public <T> boolean compare(Comparable<T> lhs, T rhs) {
throw new UnsupportedOperationException(codeString);
}
@@ -197,7 +197,7 @@
return true;
}
- public static final boolean compareGreaterThan(Comparable lhs, Object rhs) {
+ public static final <T> boolean compareGreaterThan(Comparable<T> lhs, T rhs) {
if (lhs == null) {
if (rhs != null) {
return false;
@@ -208,7 +208,7 @@
return true;
}
- public static final boolean compareGreaterThanEqualTo(Comparable lhs, Object rhs) {
+ public static final <T> boolean compareGreaterThanEqualTo(Comparable<T> lhs, T rhs) {
if (lhs == null) {
if (rhs != null) {
return false;
@@ -219,7 +219,7 @@
return true;
}
- public static final boolean compareLessThan(Comparable lhs, Object rhs) {
+ public static final <T> boolean compareLessThan(Comparable<T> lhs, T rhs) {
if (lhs == null) {
if (rhs != null) {
return false;
@@ -230,7 +230,7 @@
return true;
}
- public static final boolean compareLessThanEqualTo(Comparable lhs, Object rhs) {
+ public static final <T> boolean compareLessThanEqualTo(Comparable<T> lhs, T rhs) {
if (lhs == null) {
if (rhs != null) {
return false;
Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityOperator.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityOperator.java?rev=770034&r1=770033&r2=770034&view=diff
==============================================================================
--- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityOperator.java (original)
+++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityOperator.java Thu Apr 30 01:59:21 2009
@@ -104,36 +104,36 @@
static { register( "not-equals", NOT_EQUAL ); }
static { register( "notEqual", NOT_EQUAL ); }
public static final EntityComparisonOperator LESS_THAN = new EntityComparisonOperator(ID_LESS_THAN, "<") {
- public boolean compare(Comparable lhs, Object rhs) { return EntityComparisonOperator.compareLessThan(lhs, rhs); }
+ public <T> boolean compare(Comparable<T> lhs, T rhs) { return EntityComparisonOperator.compareLessThan(lhs, rhs); }
};
static { register( "less", LESS_THAN ); }
static { register( "less-than", LESS_THAN ); }
static { register( "lessThan", LESS_THAN ); }
public static final EntityComparisonOperator GREATER_THAN = new EntityComparisonOperator(ID_GREATER_THAN, ">") {
- public boolean compare(Comparable lhs, Object rhs) { return EntityComparisonOperator.compareGreaterThan(lhs, rhs); }
+ public <T> boolean compare(Comparable<T> lhs, T rhs) { return EntityComparisonOperator.compareGreaterThan(lhs, rhs); }
};
static { register( "greater", GREATER_THAN ); }
static { register( "greater-than", GREATER_THAN ); }
static { register( "greaterThan", GREATER_THAN ); }
public static final EntityComparisonOperator LESS_THAN_EQUAL_TO = new EntityComparisonOperator(ID_LESS_THAN_EQUAL_TO, "<=") {
- public boolean compare(Comparable lhs, Object rhs) { return EntityComparisonOperator.compareLessThanEqualTo(lhs, rhs); }
+ public <T> boolean compare(Comparable<T> lhs, T rhs) { return EntityComparisonOperator.compareLessThanEqualTo(lhs, rhs); }
};
static { register( "less-equals", LESS_THAN_EQUAL_TO ); }
static { register( "less-than-equal-to", LESS_THAN_EQUAL_TO ); }
static { register( "lessThanEqualTo", LESS_THAN_EQUAL_TO ); }
public static final EntityComparisonOperator GREATER_THAN_EQUAL_TO = new EntityComparisonOperator(ID_GREATER_THAN_EQUAL_TO, ">=") {
- public boolean compare(Comparable lhs, Object rhs) { return EntityComparisonOperator.compareGreaterThanEqualTo(lhs, rhs); }
+ public <T> boolean compare(Comparable<T> lhs, T rhs) { return EntityComparisonOperator.compareGreaterThanEqualTo(lhs, rhs); }
};
static { register( "greater-equals", GREATER_THAN_EQUAL_TO ); }
static { register( "greater-than-equal-to", GREATER_THAN_EQUAL_TO ); }
static { register( "greaterThanEqualTo", GREATER_THAN_EQUAL_TO ); }
public static final EntityComparisonOperator IN = new EntityComparisonOperator(ID_IN, "IN") {
- public boolean compare(Comparable lhs, Object rhs) { return EntityComparisonOperator.compareIn(lhs, rhs); }
+ public <T> boolean compare(Comparable<T> lhs, T rhs) { return EntityComparisonOperator.compareIn(lhs, rhs); }
protected void makeRHSWhereStringValue(ModelEntity entity, List<EntityConditionParam> entityConditionParams, StringBuilder sb, ModelField field, Object rhs, DatasourceInfo datasourceInfo) { appendRHSList(entityConditionParams, sb, field, rhs); }
};
static { register( "in", IN ); }
public static final EntityComparisonOperator BETWEEN = new EntityComparisonOperator(ID_BETWEEN, "BETWEEN") {
- public boolean compare(Comparable lhs, Object rhs) { return EntityComparisonOperator.compareIn(lhs, rhs); }
+ public <T> boolean compare(Comparable<T> lhs, T rhs) { return EntityComparisonOperator.compareIn(lhs, rhs); }
protected void makeRHSWhereStringValue(ModelEntity entity, List<EntityConditionParam> entityConditionParams, StringBuilder sb, ModelField field, Object rhs, DatasourceInfo datasourceInfo) { appendRHSBetweenList(entityConditionParams, sb, field, rhs); }
};
static { register( "between", BETWEEN ); }
@@ -148,11 +148,11 @@
};
static { register( "like", LIKE ); }
public static final EntityComparisonOperator NOT_LIKE = new EntityComparisonOperator(ID_NOT_LIKE, "NOT LIKE") {
- public boolean compare(Comparable lhs, Object rhs) { return !EntityComparisonOperator.compareLike(lhs, rhs); }
+ public <T> boolean compare(Comparable<T> lhs, T rhs) { return !EntityComparisonOperator.compareLike(lhs, rhs); }
};
static { register( "not-like", NOT_LIKE); }
public static final EntityComparisonOperator NOT_IN = new EntityComparisonOperator(ID_NOT_IN, "NOT IN") {
- public boolean compare(Comparable lhs, Object rhs) { return !EntityComparisonOperator.compareIn(lhs, rhs); }
+ public <T> boolean compare(Comparable<T> lhs, T rhs) { return !EntityComparisonOperator.compareIn(lhs, rhs); }
protected void makeRHSWhereStringValue(ModelEntity entity, List<EntityConditionParam> entityConditionParams, StringBuilder sb, ModelField field, Object rhs, DatasourceInfo datasourceInfo) { appendRHSList(entityConditionParams, sb, field, rhs); }
};
static { register( "not-in", NOT_IN ); }