You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/07 02:23:59 UTC
[GitHub] [spark] viirya commented on a diff in pull request #37085: [SPARK-39679][SQL] TakeOrderedAndProjectExec should respect child output ordering
viirya commented on code in PR #37085:
URL: https://github.com/apache/spark/pull/37085#discussion_r915391981
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/TakeOrderedAndProjectSuite.scala:
##########
@@ -93,4 +93,38 @@ class TakeOrderedAndProjectSuite extends SparkPlanTest with SharedSparkSession {
}
}
}
+
+ test("TakeOrderedAndProject.doExecute with local sort") {
Review Comment:
Hmm, isn't this test already passed without the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org