You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "arunpandianp (via GitHub)" <gi...@apache.org> on 2024/02/02 09:12:16 UTC
[PR] Add grpc-services, grpc-utils to vendored grpc [beam]
arunpandianp opened a new pull request, #30196:
URL: https://github.com/apache/beam/pull/30196
grpc-services is needed to get Channelz information #24835. grpc-utils is a dependency of grpc-services
checkJavaLinkage didn't report any new failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add grpc-services, grpc-utils to vendored grpc [beam]
Posted by "arunpandianp (via GitHub)" <gi...@apache.org>.
arunpandianp commented on PR #30196:
URL: https://github.com/apache/beam/pull/30196#issuecomment-1923382815
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add grpc-services, grpc-utils to vendored grpc [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #30196:
URL: https://github.com/apache/beam/pull/30196#issuecomment-1924450592
FWIW I think this change is OK but it is some work to then re-release the vendored artifact. So using today's processes you just have to budget for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add grpc-services, grpc-utils to vendored grpc [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #30196:
URL: https://github.com/apache/beam/pull/30196#issuecomment-1924448566
The main reason for vendoring is that the things we vendor have frequent backwards-incompatible and forward-incompatible changes and are widely used so that they often cause conflicts with IOs and user pipelines. Perhaps we can remain vendored while decreasing toil but that would require some cleverness. I think adding more related libraries to a massive vendor uberjar so we still only have one "release" could be possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add grpc-services, grpc-utils to vendored grpc [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30196:
URL: https://github.com/apache/beam/pull/30196#issuecomment-1923384353
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add grpc-services, grpc-utils to vendored grpc [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #30196:
URL: https://github.com/apache/beam/pull/30196#issuecomment-1924039025
The current vendor process does not afford frequent change. If there are recurring changes then it needs to use unvendored grpc, or we unvendor grpc at all
CC: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add grpc-services, grpc-utils to vendored grpc [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #30196:
URL: https://github.com/apache/beam/pull/30196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add grpc-services, grpc-utils to vendored grpc [beam]
Posted by "arunpandianp (via GitHub)" <gi...@apache.org>.
arunpandianp commented on PR #30196:
URL: https://github.com/apache/beam/pull/30196#issuecomment-1929181943
Tested the upgrade here https://github.com/apache/beam/pull/30212. Let me know if anything else is required for merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org