You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/24 17:33:21 UTC
[GitHub] [flink] snuyanzin opened a new pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command
snuyanzin opened a new pull request #18487:
URL: https://github.com/apache/flink/pull/18487
## What is the purpose of the change
This PR introduces a command `SHOW CONNECTORS`
## Brief change log
- Added support `SHOW CONNECTORS` in parser, converter
- Make _org.apache.flink.table.factories.FactoryUtil#discoverFactory_ public
- Added test in `function.q`
## Verifying this change
Added test in `function.q`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
Make _org.apache.flink.table.factories.FactoryUtil#discoverFactory_ public
- The serializers: ( no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes )
- If yes, how is the feature documented? (docs )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18487:
URL: https://github.com/apache/flink/pull/18487#issuecomment-1020364211
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f21ff12e6f34e59cc11d951088135d9e017ce9b8 (Mon Jan 24 17:38:07 UTC 2022)
**Warnings:**
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-25788).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18487:
URL: https://github.com/apache/flink/pull/18487#issuecomment-1020364211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18487:
URL: https://github.com/apache/flink/pull/18487#issuecomment-1020369201
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f21ff12e6f34e59cc11d951088135d9e017ce9b8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30081",
"triggerID" : "f21ff12e6f34e59cc11d951088135d9e017ce9b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f21ff12e6f34e59cc11d951088135d9e017ce9b8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18487:
URL: https://github.com/apache/flink/pull/18487#issuecomment-1020369201
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f21ff12e6f34e59cc11d951088135d9e017ce9b8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f21ff12e6f34e59cc11d951088135d9e017ce9b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f21ff12e6f34e59cc11d951088135d9e017ce9b8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18487:
URL: https://github.com/apache/flink/pull/18487#issuecomment-1020369201
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f21ff12e6f34e59cc11d951088135d9e017ce9b8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30081",
"triggerID" : "f21ff12e6f34e59cc11d951088135d9e017ce9b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f21ff12e6f34e59cc11d951088135d9e017ce9b8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18487:
URL: https://github.com/apache/flink/pull/18487#issuecomment-1020369201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18487:
URL: https://github.com/apache/flink/pull/18487#discussion_r839622978
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -1899,4 +1905,14 @@ public TableResult executeJsonPlan(String jsonPlan) {
}
return executeInternal(transformations, sinkIdentifierNames);
}
+
+ public String[] showConnectors() {
+ return FactoryUtil.discoverFactories(userClassLoader).stream()
+ .filter(
+ t ->
+ t instanceof DynamicTableSourceFactory
+ || t instanceof DynamicTableSinkFactory)
Review comment:
I guess my next question is what about formats?
I was wondering, what if the SHOW CONNECTORS returns a table like that?
| Name | Type |
|-------|--------------|
| kafka | source, sink |
| csv | format |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org