You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Adam Antal (Jira)" <ji...@apache.org> on 2019/10/07 08:33:01 UTC
[jira] [Updated] (HADOOP-16511) [hadoop-hdfs] Fix order of actual
and expected expression in assert statements
[ https://issues.apache.org/jira/browse/HADOOP-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Antal updated HADOOP-16511:
--------------------------------
Parent: (was: HADOOP-12693)
Issue Type: Bug (was: Sub-task)
> [hadoop-hdfs] Fix order of actual and expected expression in assert statements
> ------------------------------------------------------------------------------
>
> Key: HADOOP-16511
> URL: https://issues.apache.org/jira/browse/HADOOP-16511
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Adam Antal
> Priority: Major
>
> Fix order of actual and expected expression in assert statements which gives misleading message when test case fails. Attached file has some of the places where it is placed wrongly.
> {code:java}
> [ERROR] testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService) Time elapsed: 3.385 s <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be used for new test cases which avoids such mistakes.
> This is a follow-up jira for the hadoop-hdfs project.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org