[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11366: refactor: Use Antd Modals instead of react-bootstrap Modals

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #11366:
URL: https://github.com/apache/incubator-superset/pull/11366#discussion_r512769880



##########
File path: superset-frontend/src/common/components/Modal.tsx
##########
@@ -121,12 +137,15 @@ export default function Modal({
       ]
     : footer;
 
+  const modalWidth = width || (responsive ? 'calc(100vw - 24px)' : '600px');

Review comment:
       I changed it to `responsive ? '100vw' : '600px'` and used `padding: 0 ${theme.gridUnits * 3}px` in styled. The reason for that is that Antd Modal uses default value for width and puts it in `style`, so I'd need to use `!important` to override it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org