[GitHub] reddycharan opened a new pull request #1862: Fix selectFromNetworkLocation in RackawareEnsemblePlacementPolicyImpl

[GitBox <gi...@apache.org>]

reddycharan opened a new pull request #1862: Fix selectFromNetworkLocation in RackawareEnsemblePlacementPolicyImpl
URL: https://github.com/apache/bookkeeper/pull/1862
 
 
   
   Descriptions of the changes in this PR:
   
   Since beginning, selectFromNetworkLocation(excludeRacks, excludeBookies,..)
   method kind of ignores predicate/ensemble passed to that method
   https://github.com/apache/bookkeeper/blob/branch-4.7/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L694.
   
   This was kind of ok, because so far effectively this method is called from only
   one place - https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L612,
   which passes TruePredicate.INSTANCE and EnsembleForReplacementWithNoConstraints.INSTANCE.
   
   But it is not ideal to ignore those parameters in selectFromNetworkLocation(excludeRacks, excludeBookies,..),
   from future usage perspective. So passing the received predicate and ensemble to the underlying calls.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services