You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@infra.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2012/06/06 21:32:23 UTC

[jira] [Created] (INFRA-4886) when Jenkins tests a patch, it should compile with -Pnative

Colin Patrick McCabe created INFRA-4886:
-------------------------------------------

             Summary: when Jenkins tests a patch, it should compile with -Pnative 
                 Key: INFRA-4886
                 URL: https://issues.apache.org/jira/browse/INFRA-4886
             Project: Infrastructure
          Issue Type: Improvement
      Security Level: public (Regular issues)
          Components: Jenkins
            Reporter: Colin Patrick McCabe
            Priority: Minor


It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.

Currently, we don't seem to build the native code at all when testing patches.  Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.

It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs).  However, some testing is sure better than none.  I believe with cmake the performance overhead of -Pnative should be very minimal.

This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (INFRA-4886) when Jenkins tests a patch, it should compile with -Pnative

Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/INFRA-4886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

#asfinfra IRC Bot closed INFRA-4886.
------------------------------------

    
> when Jenkins tests a patch, it should compile with -Pnative 
> ------------------------------------------------------------
>
>                 Key: INFRA-4886
>                 URL: https://issues.apache.org/jira/browse/INFRA-4886
>             Project: Infrastructure
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Jenkins
>            Reporter: Colin Patrick McCabe
>            Priority: Minor
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches.  Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs).  However, some testing is sure better than none.  I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (INFRA-4886) when Jenkins tests a patch, it should compile with -Pnative

Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/INFRA-4886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290566#comment-13290566 ] 

Colin Patrick McCabe commented on INFRA-4886:
---------------------------------------------

Thanks for the clarification... I'll move this to HADOOP.
                
> when Jenkins tests a patch, it should compile with -Pnative 
> ------------------------------------------------------------
>
>                 Key: INFRA-4886
>                 URL: https://issues.apache.org/jira/browse/INFRA-4886
>             Project: Infrastructure
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Jenkins
>            Reporter: Colin Patrick McCabe
>            Priority: Minor
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches.  Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs).  However, some testing is sure better than none.  I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (INFRA-4886) when Jenkins tests a patch, it should compile with -Pnative

Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/INFRA-4886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe resolved INFRA-4886.
-----------------------------------------

    Resolution: Duplicate

Duplicate of HADOOP-8488
                
> when Jenkins tests a patch, it should compile with -Pnative 
> ------------------------------------------------------------
>
>                 Key: INFRA-4886
>                 URL: https://issues.apache.org/jira/browse/INFRA-4886
>             Project: Infrastructure
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Jenkins
>            Reporter: Colin Patrick McCabe
>            Priority: Minor
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches.  Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs).  However, some testing is sure better than none.  I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (INFRA-4886) when Jenkins tests a patch, it should compile with -Pnative

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/INFRA-4886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290551#comment-13290551 ] 

Todd Lipcon commented on INFRA-4886:
------------------------------------

I'm confused why this is in the INFRA JIRA -- the test-patch script and Jenkins configs are managed by the Hadoop project, not the central infra team. Want to move this back to the Hadoop project, or just reopen the original JIRA?
                
> when Jenkins tests a patch, it should compile with -Pnative 
> ------------------------------------------------------------
>
>                 Key: INFRA-4886
>                 URL: https://issues.apache.org/jira/browse/INFRA-4886
>             Project: Infrastructure
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Jenkins
>            Reporter: Colin Patrick McCabe
>            Priority: Minor
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches.  Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs).  However, some testing is sure better than none.  I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira