You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Aditi Dixit <ad...@gmail.com> on 2015/08/15 12:50:07 UTC
Review Request 37501: Add support for removing capabilities.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37501/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-3258
https://issues.apache.org/jira/browse/MESOS-3258
Repository: mesos
Description
-------
The allocator automatically assumes non-revocable resources whenever a framework registers or re-registers, unless it is defined in the FrameworkInfo.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
src/tests/oversubscription_tests.cpp d41f030c1bc259c86dab0d268d2f36ce410cd505
Diff: https://reviews.apache.org/r/37501/diff/
Testing
-------
make check
Thanks,
Aditi Dixit
Re: Review Request 37501: Add support for removing capabilities.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37501/#review96232
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 15, 2015, 4:35 p.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37501/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2015, 4:35 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3258
> https://issues.apache.org/jira/browse/MESOS-3258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator automatically assumes non-revocable resources whenever a framework registers or re-registers, unless it is defined in the FrameworkInfo.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/tests/oversubscription_tests.cpp d41f030c1bc259c86dab0d268d2f36ce410cd505
>
> Diff: https://reviews.apache.org/r/37501/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 37501: Add support for removing capabilities.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37501/#review95529
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37501]
All tests passed.
- Mesos ReviewBot
On Aug. 15, 2015, 4:35 p.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37501/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2015, 4:35 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3258
> https://issues.apache.org/jira/browse/MESOS-3258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator automatically assumes non-revocable resources whenever a framework registers or re-registers, unless it is defined in the FrameworkInfo.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/tests/oversubscription_tests.cpp d41f030c1bc259c86dab0d268d2f36ce410cd505
>
> Diff: https://reviews.apache.org/r/37501/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 37501: Add support for removing capabilities.
Posted by Aditi Dixit <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37501/
-----------------------------------------------------------
(Updated Aug. 15, 2015, 4:35 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3258
https://issues.apache.org/jira/browse/MESOS-3258
Repository: mesos
Description
-------
The allocator automatically assumes non-revocable resources whenever a framework registers or re-registers, unless it is defined in the FrameworkInfo.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
src/tests/oversubscription_tests.cpp d41f030c1bc259c86dab0d268d2f36ce410cd505
Diff: https://reviews.apache.org/r/37501/diff/
Testing
-------
make check
Thanks,
Aditi Dixit
Re: Review Request 37501: Add support for removing capabilities.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37501/#review95511
-----------------------------------------------------------
Bad patch!
Reviews applied: [37501]
Failed command: ./support/apply-review.sh -n -r 37501
Error:
2015-08-15 11:08:50 URL:https://reviews.apache.org/r/37501/diff/raw/ [4846/4846] -> "37501.patch" [1]
error: patch failed: src/master/master.hpp:1519
error: src/master/master.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Aug. 15, 2015, 10:50 a.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37501/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2015, 10:50 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3258
> https://issues.apache.org/jira/browse/MESOS-3258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator automatically assumes non-revocable resources whenever a framework registers or re-registers, unless it is defined in the FrameworkInfo.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629
> src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e
> src/tests/oversubscription_tests.cpp d41f030c1bc259c86dab0d268d2f36ce410cd505
>
> Diff: https://reviews.apache.org/r/37501/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>