You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/04 05:50:26 UTC
[GitHub] [superset] Neeraj-2307 opened a new pull request, #20264: docs: Added details to Druid connection string
Neeraj-2307 opened a new pull request, #20264:
URL: https://github.com/apache/superset/pull/20264
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
While linking Superset to Druid the correct connection string is very important however in the docs it is not well explained , so I added a the description to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Neeraj-2307 commented on a diff in pull request #20264: docs: Added details to Druid connection string
Posted by GitBox <gi...@apache.org>.
Neeraj-2307 commented on code in PR #20264:
URL: https://github.com/apache/superset/pull/20264#discussion_r892438652
##########
docs/docs/databases/druid.mdx:
##########
@@ -18,6 +18,7 @@ The connection string looks like:
```
druid://<User>:<password>@<Host>:<Port-default-9088>/druid/v2/sql
```
+Where User and password are the credentials of your **Druid Database** , Host is your machine's IP address and Port is the port at which **Druid Database** is running.
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify merged pull request #20264: docs: Added details to Druid connection string
Posted by GitBox <gi...@apache.org>.
srinify merged PR #20264:
URL: https://github.com/apache/superset/pull/20264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #20264: docs: Added details to Druid connection string
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #20264:
URL: https://github.com/apache/superset/pull/20264#issuecomment-1156762511
@srinify how does this look to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on a diff in pull request #20264: docs: Added details to Druid connection string
Posted by GitBox <gi...@apache.org>.
srinify commented on code in PR #20264:
URL: https://github.com/apache/superset/pull/20264#discussion_r892436765
##########
docs/docs/databases/druid.mdx:
##########
@@ -18,6 +18,7 @@ The connection string looks like:
```
druid://<User>:<password>@<Host>:<Port-default-9088>/druid/v2/sql
```
+Where User and password are the credentials of your **Druid Database** , Host is your machine's IP address and Port is the port at which **Druid Database** is running.
Review Comment:
Some quick feedback! It would be a bit more visually cleaner to turn this into a list:
"Here's a breakdown of the key parts of this connection string:
- User: username portion of the credentials needed to connect to your database
- Password: password portion of the credentials needed to connect to your database
- Host: IP address (or URL) of the host machine that's running your database
- Port: specific port that's exposed on your host machine where your database is running"
This way, we can also add this to the other database pages as well and it's a bit more generalized!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on pull request #20264: docs: Added details to Druid connection string
Posted by GitBox <gi...@apache.org>.
srinify commented on PR #20264:
URL: https://github.com/apache/superset/pull/20264#issuecomment-1149975227
Hey @Neeraj-2307 quick comment / piece of feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on pull request #20264: docs: Added details to Druid connection string
Posted by GitBox <gi...@apache.org>.
srinify commented on PR #20264:
URL: https://github.com/apache/superset/pull/20264#issuecomment-1158953075
Thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org