You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2016/12/15 17:51:15 UTC
Review Request 54791: After rescanning yarn queue,
Ambari still asks for RM to be restarted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54791/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-19216
https://issues.apache.org/jira/browse/AMBARI-19216
Repository: ambari
Description
-------
Ran into this while troubleshooting a yarn issue.
1. Go to yarn view, and change any value in one of your queues.
2. Save and Refresh queues
3 Go to Yarn service. It now says RM needs to be restarted (**This is false, and did not flag in 2.2.x versions of Ambari**)
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py cb4fcb9
Diff: https://reviews.apache.org/r/54791/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 54791: After rescanning yarn queue,
Ambari still asks for RM to be restarted
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54791/#review159624
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Dec. 15, 2016, 12:51 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54791/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 12:51 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-19216
> https://issues.apache.org/jira/browse/AMBARI-19216
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ran into this while troubleshooting a yarn issue.
> 1. Go to yarn view, and change any value in one of your queues.
> 2. Save and Refresh queues
> 3 Go to Yarn service. It now says RM needs to be restarted (**This is false, and did not flag in 2.2.x versions of Ambari**)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py cb4fcb9
>
> Diff: https://reviews.apache.org/r/54791/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 54791: After rescanning yarn queue,
Ambari still asks for RM to be restarted
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54791/#review159328
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On \u0413\u0440\u0443. 15, 2016, 5:51 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54791/
> -----------------------------------------------------------
>
> (Updated \u0413\u0440\u0443. 15, 2016, 5:51 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-19216
> https://issues.apache.org/jira/browse/AMBARI-19216
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ran into this while troubleshooting a yarn issue.
> 1. Go to yarn view, and change any value in one of your queues.
> 2. Save and Refresh queues
> 3 Go to Yarn service. It now says RM needs to be restarted (**This is false, and did not flag in 2.2.x versions of Ambari**)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py cb4fcb9
>
> Diff: https://reviews.apache.org/r/54791/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 54791: After rescanning yarn queue,
Ambari still asks for RM to be restarted
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On \u0414\u0435\u043a. 16, 2016, 3:26 \u043f.\u043f., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/ActionQueue.py, lines 430-439
> > <https://reviews.apache.org/r/54791/diff/1/?file=1586488#file1586488line430>
> >
> > Where in the Ambari Server code does it send down `forceRefreshConfigTags` - I couldn't find any spot where this is injected into the parameters being set on the command for the agent.
It's a parameter for REFRESHQUEUE command:
from ConfigurationService.java :
private static final String REFRESH_RM_REQUEST_DATA =
"{\n" +
" \"RequestInfo\" : {\n" +
" \"command\" : \"REFRESHQUEUES\",\n" +
" \"context\" : \"Refresh YARN Capacity Scheduler\"\n" +
" \"parameters/forceRefreshConfigTags\" : \"capacity-scheduler\"\n" +
" },\n" +
" \"Requests/resource_filters\": [{\n" +
" \"service_name\" : \"YARN\",\n" +
" \"component_name\" : \"RESOURCEMANAGER\",\n" +
" \"hosts\" : \"%s\"\n" +
" }]\n" +
"}";
All the parameters from the command are sent to ambari-agent from the server side:
@SerializedName("commandParams")
private Map<String, String> commandParams = new HashMap<String, String>();
In AmbariManagementControllerImpl.createHostAction():
execCmd.setCommandParams(commandParams);
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54791/#review159449
-----------------------------------------------------------
On \u0414\u0435\u043a. 15, 2016, 5:51 \u043f.\u043f., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54791/
> -----------------------------------------------------------
>
> (Updated \u0414\u0435\u043a. 15, 2016, 5:51 \u043f.\u043f.)
>
>
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-19216
> https://issues.apache.org/jira/browse/AMBARI-19216
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ran into this while troubleshooting a yarn issue.
> 1. Go to yarn view, and change any value in one of your queues.
> 2. Save and Refresh queues
> 3 Go to Yarn service. It now says RM needs to be restarted (**This is false, and did not flag in 2.2.x versions of Ambari**)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py cb4fcb9
>
> Diff: https://reviews.apache.org/r/54791/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 54791: After rescanning yarn queue,
Ambari still asks for RM to be restarted
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54791/#review159449
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/ActionQueue.py (lines 430 - 439)
<https://reviews.apache.org/r/54791/#comment230459>
Where in the Ambari Server code does it send down `forceRefreshConfigTags` - I couldn't find any spot where this is injected into the parameters being set on the command for the agent.
- Jonathan Hurley
On Dec. 15, 2016, 12:51 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54791/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 12:51 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-19216
> https://issues.apache.org/jira/browse/AMBARI-19216
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ran into this while troubleshooting a yarn issue.
> 1. Go to yarn view, and change any value in one of your queues.
> 2. Save and Refresh queues
> 3 Go to Yarn service. It now says RM needs to be restarted (**This is false, and did not flag in 2.2.x versions of Ambari**)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py cb4fcb9
>
> Diff: https://reviews.apache.org/r/54791/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>