You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/03/12 16:33:35 UTC
[GitHub] [phoenix] kadirozde opened a new pull request #734: PHOENIX-5768 Supporting partial overwrites for immutable tables with …
kadirozde opened a new pull request #734: PHOENIX-5768 Supporting partial overwrites for immutable tables with …
URL: https://github.com/apache/phoenix/pull/734
…indexes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #734: PHOENIX-5768 Supporting partial overwrites for immutable tables with …
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #734: PHOENIX-5768 Supporting partial overwrites for immutable tables with …
URL: https://github.com/apache/phoenix/pull/734#discussion_r391875046
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##########
@@ -195,6 +198,37 @@ public void testPartialRowUpdate() throws Exception {
conn.close();
}
+ @Test
Review comment:
Good to have a comment explaining what this is (and discouraging people from trying it :-) )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] kadirozde commented on a change in pull request #734: PHOENIX-5768 Supporting partial overwrites for immutable tables with …
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #734: PHOENIX-5768 Supporting partial overwrites for immutable tables with …
URL: https://github.com/apache/phoenix/pull/734#discussion_r392708148
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##########
@@ -195,6 +198,37 @@ public void testPartialRowUpdate() throws Exception {
conn.close();
}
+ @Test
Review comment:
I added the comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] kadirozde merged pull request #734: PHOENIX-5768 Supporting partial overwrites for immutable tables with …
Posted by GitBox <gi...@apache.org>.
kadirozde merged pull request #734: PHOENIX-5768 Supporting partial overwrites for immutable tables with …
URL: https://github.com/apache/phoenix/pull/734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services