You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2016/03/03 21:42:10 UTC
Review Request 44357: Added check for Appc image's dependency id.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44357/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Since dependency's image id is an optional field, we need to check for its
existence before using it for fetching an image.
Diffs
-----
src/slave/containerizer/mesos/provisioner/appc/store.cpp 1e893daa63d48d4290bf4c4e8655ca3f39133c3e
Diff: https://reviews.apache.org/r/44357/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 44357: Added check for Appc image's dependency id.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44357/#review121939
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 3, 2016, 8:42 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44357/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 8:42 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since dependency's image id is an optional field, we need to check for its
> existence before using it for fetching an image.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/appc/store.cpp 1e893daa63d48d4290bf4c4e8655ca3f39133c3e
>
> Diff: https://reviews.apache.org/r/44357/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>