You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Mark Struberg <st...@yahoo.de> on 2012/11/15 19:05:59 UTC
JspStateManagerImpl vs StateManagerImpl
We have 2 StateManager implementations. Guess the following classes can now get deleted?
* JspStateManagerImpl
* MyfacesStateManager
or alternate question: the HtmlResponseStateManager extends MyfacesResponseStateManager.
If we keep that pattern, why does the StateManagerImpl which seems to be the 'new' one doesn't extend MyFacesStateManager?
Either keep both or delete both.
Btw: such classes _always_ need to get annotated with @Deprecated + JavaDoc or even better they should get immediately deleted.
LieGrue,
strub
Re: JspStateManagerImpl vs StateManagerImpl
Posted by Mark Struberg <st...@yahoo.de>.
oki, great. Let's get rid of it. It just makes it harder to read the code and do maintenance.
I gonna creat a JIRA for it and remove it.
LieGrue,
strub
----- Original Message -----
> From: Leonardo Uribe <lu...@gmail.com>
> To: MyFaces Development <de...@myfaces.apache.org>; Mark Struberg <st...@yahoo.de>
> Cc:
> Sent: Thursday, November 15, 2012 7:29 PM
> Subject: Re: JspStateManagerImpl vs StateManagerImpl
>
> Hi
>
> 2012/11/15 Mark Struberg <st...@yahoo.de>:
>> We have 2 StateManager implementations. Guess the following classes can now
> get deleted?
>>
>> * JspStateManagerImpl
>>
>> * MyfacesStateManager
>>
>> or alternate question: the HtmlResponseStateManager extends
> MyfacesResponseStateManager.
>> If we keep that pattern, why does the StateManagerImpl which seems to be
> the 'new' one doesn't extend MyFacesStateManager?
>>
>
> MyfacesResponseStateManager is a leftover from jsf 1.1.x. In that
> time, the idea was to store the state using javascript but right now
> that class does nothing. Remove that code is a valid option.
>
>> Either keep both or delete both.
>> Btw: such classes _always_ need to get annotated with @Deprecated + JavaDoc
> or even better they should get immediately deleted.
>>
>
> I would vote for delete them, because that part was not fully done, so
> it has never worked.
>
>>
>> LieGrue,
>> strub
>>
>
Re: JspStateManagerImpl vs StateManagerImpl
Posted by Leonardo Uribe <lu...@gmail.com>.
Hi
2012/11/15 Mark Struberg <st...@yahoo.de>:
> We have 2 StateManager implementations. Guess the following classes can now get deleted?
>
> * JspStateManagerImpl
>
> * MyfacesStateManager
>
> or alternate question: the HtmlResponseStateManager extends MyfacesResponseStateManager.
> If we keep that pattern, why does the StateManagerImpl which seems to be the 'new' one doesn't extend MyFacesStateManager?
>
MyfacesResponseStateManager is a leftover from jsf 1.1.x. In that
time, the idea was to store the state using javascript but right now
that class does nothing. Remove that code is a valid option.
> Either keep both or delete both.
> Btw: such classes _always_ need to get annotated with @Deprecated + JavaDoc or even better they should get immediately deleted.
>
I would vote for delete them, because that part was not fully done, so
it has never worked.
>
> LieGrue,
> strub
>