[GitHub] [incubator-mxnet] MoisesHer commented on pull request #18779: Support extra inputs for subgraph ops

[GitBox <gi...@apache.org>]

MoisesHer commented on pull request #18779:
URL: https://github.com/apache/incubator-mxnet/pull/18779#issuecomment-671738680


   Thanks Sam, I think the way to add new params is very clear
   just couple of questions / minor things about documentation on lib_pass/README.md
   
   - is it required the double connection between nodes?  Here:
   ```
   n1->outputs.push_back({n2,1});
   n2->inputs.push_back({n1,0});
   ```
   will not be enough to do something like
   ` n2->inputs[1].node = n1`
   
   - Can you add the same figure in README as you have here?
   - Example call for adding params (alloc_arg) here has a different signature as in lib_pass/README.md (+- input_name)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org