You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Jochen Kemnade (JIRA)" <ji...@apache.org> on 2014/08/21 13:17:11 UTC
[jira] [Commented] (TAP5-2337) Reduce number of calls of
AbstractStringBuilder.expandCapacity
[ https://issues.apache.org/jira/browse/TAP5-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105304#comment-14105304 ]
Jochen Kemnade commented on TAP5-2337:
--------------------------------------
That patch changes a lot of method signatures. Can we determine how long the string will become before creating the {{StringBuilder}} and the create it with the correct capacity?
> Reduce number of calls of AbstractStringBuilder.expandCapacity
> --------------------------------------------------------------
>
> Key: TAP5-2337
> URL: https://issues.apache.org/jira/browse/TAP5-2337
> Project: Tapestry 5
> Issue Type: Improvement
> Reporter: Michael Mikhulya
> Priority: Minor
> Labels: performance
> Attachments: 0001-TAP5-2337-Reduce-number-of-calls-of-AbstractStringBu.patch
>
>
> During profiling of Tapestry framework I found that AbstractStringBuilder.expandCapacity is called very frequently.
> There is a patch that get rid of creation StringBuilder with following calls of expandCapacity (which allocate memory and copy current content into it).
> I have to thank Dmitriy Ilyin, who helped me to investigate the issue and to find the simplest solution (actually we get a little bit less code while improving performance).
> With this improvement time per request decreased on 0.5ms (1% of overall time)on our test. All measurements were done with apache benchmark after warm up phase.
--
This message was sent by Atlassian JIRA
(v6.2#6252)