You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/21 10:41:07 UTC

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #3132: nuttx: update licenses to Apache

jerpelea opened a new pull request #3132:
URL: https://github.com/apache/incubator-nuttx/pull/3132


   ## Summary
   several authors have submitted the SGA or ICLA and we can migrate the licenses to Apache.
   Alan Carvalho de Assis
   David S. Alessio
   David Sidrane
   Gregory Nutt
   Sebastien Lorquet
   
   ## Impact
   NONE
   
   ## Testing
   NONE


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3132: nuttx: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3132:
URL: https://github.com/apache/incubator-nuttx/pull/3132#issuecomment-804535412


   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3132: nuttx: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3132:
URL: https://github.com/apache/incubator-nuttx/pull/3132#issuecomment-804278614


   > @xiaoxiang781216
   > boards/arm/imxrt/imxrt1060-evk/src/imxrt_boot.c:70:36: error: Space precedes right parenthesis
   > remains
   
   I will take a look after merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on pull request #3132: nuttx: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #3132:
URL: https://github.com/apache/incubator-nuttx/pull/3132#issuecomment-804314447


   are you merging it or should I ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3132: nuttx: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3132:
URL: https://github.com/apache/incubator-nuttx/pull/3132


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #3132: nuttx: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #3132:
URL: https://github.com/apache/incubator-nuttx/pull/3132#discussion_r598775261



##########
File path: boards/arm/imxrt/imxrt1060-evk/src/imxrt_boot.c
##########
@@ -64,9 +64,10 @@ void imxrt_ocram_initialize(void)
   regval = getreg32(IMXRT_IOMUXC_GPR_GPR16);
   putreg32(regval | GPR_GPR16_FLEXRAM_BANK_CFG_SELF, IMXRT_IOMUXC_GPR_GPR16);
 
-  for (src = (uint32_t *)(LOCATE_IN_SRC(g_boot_data.start) + g_boot_data.size),
+  for (src = (uint32_t *)(LOCATE_IN_SRC(g_boot_data.start) +
+       g_boot_data.size),
        dest = (uint32_t *)(g_boot_data.start + g_boot_data.size);
-       dest < (uint32_t *) &_etext;)
+       dest < (uint32_t *) &_etext);

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #3132: nuttx: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #3132:
URL: https://github.com/apache/incubator-nuttx/pull/3132#issuecomment-804201000


   @xiaoxiang781216 
   boards/arm/imxrt/imxrt1060-evk/src/imxrt_boot.c:70:36: error: Space precedes right parenthesis 
   remains
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on pull request #3132: nuttx: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #3132:
URL: https://github.com/apache/incubator-nuttx/pull/3132#issuecomment-804201000


   @xiaoxiang781216 
   boards/arm/imxrt/imxrt1060-evk/src/imxrt_boot.c:70:36: error: Space precedes right parenthesis
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3132: nuttx: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3132:
URL: https://github.com/apache/incubator-nuttx/pull/3132#discussion_r598770433



##########
File path: boards/arm/imxrt/imxrt1060-evk/src/imxrt_boot.c
##########
@@ -64,9 +64,10 @@ void imxrt_ocram_initialize(void)
   regval = getreg32(IMXRT_IOMUXC_GPR_GPR16);
   putreg32(regval | GPR_GPR16_FLEXRAM_BANK_CFG_SELF, IMXRT_IOMUXC_GPR_GPR16);
 
-  for (src = (uint32_t *)(LOCATE_IN_SRC(g_boot_data.start) + g_boot_data.size),
+  for (src = (uint32_t *)(LOCATE_IN_SRC(g_boot_data.start) +
+       g_boot_data.size),
        dest = (uint32_t *)(g_boot_data.start + g_boot_data.size);
-       dest < (uint32_t *) &_etext;)
+       dest < (uint32_t *) &_etext);

Review comment:
       change to:
   ```
   dest < (uint32_t *) &_etext; )
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #3132: nuttx: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #3132:
URL: https://github.com/apache/incubator-nuttx/pull/3132#issuecomment-804314447


   @xiaoxiang781216 are you merging it or should I ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org